From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning
Date: Fri, 05 Mar 2010 08:18:52 -0600 [thread overview]
Message-ID: <4B9112CC.9020302@windriver.com> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D187435EB9A@SC-VEXCH4.marvell.com>
Prafulla Wadaskar wrote:
>
>
>> -----Original Message-----
>> From: Tom [mailto:Tom.Rix at windriver.com]
>> Sent: Thursday, March 04, 2010 7:25 PM
>> To: Prafulla Wadaskar
>> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik
>> Subject: Re: [U-Boot] [PATCH] arm: kirkwood: suen3: fixed
>> build warning
>>
>> Prafulla Wadaskar wrote:
>>> This patch fixes following build warning
>>>
>>> Invalid Kwbimage command Type - valid names are: BOOT_FROM,
>> NAND_ECC_MODE, NAND_PAGE_SIZE, SATA_PIO_MODE, DDR_INIT_DELAY,
>> DATA, , spi, nand, sata, pex, uart
>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>>> ---
>>> board/keymile/km_arm/kwbimage.cfg | 3 +--
>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/board/keymile/km_arm/kwbimage.cfg
>> b/board/keymile/km_arm/kwbimage.cfg
>>> index d6edd27..26d6aa0 100644
>>> --- a/board/keymile/km_arm/kwbimage.cfg
>>> +++ b/board/keymile/km_arm/kwbimage.cfg
>>> @@ -64,7 +64,6 @@ DATA 0xFFD01400 0x43000400 # SDRAM
>> Configuration Register
>>> # bit31-30: 01
>>>
>>> DATA 0xFFD01404 0x36343000 # DDR Controller Control Low
>>> - 0x38543000
>>> # bit 3-0: 0 reserved
>>> # bit 4: 0=addr/cmd in smame cycle
>>> # bit 5: 0=clk is driven during self refresh, we don't
>> care for APX
>>> @@ -170,7 +169,7 @@ DATA 0xFFD0149C 0x0000E90F # CPU
>> ODT Control
>>> # bit11-10:2, DQ_ODTSel. ODT select turned on, 75 ohm
>>>
>>> DATA 0xFFD01480 0x00000001 # DDR Initialization Control
>>> -#bit0=1, enable DDR init upon this register write
>>> +# bit0=1, enable DDR init upon this register write
>>>
>>> # End of Header extension
>>> DATA 0x0 0x0
>> This patch did not fix any of the warnings I saw.
>> Please recheck.
>
> Hi Tom
> I am sorry to say,
> it is not build warning but it is runtime stderr generated during kwbimage.cfg parsing.
> This patch removes above mentioned "Invalid Kwbimage command Type" error reported by mkimage tool during u-boot.kwb target creation for this board.
>
Ah!
Ok that helps.
I did not hold up your pull request for this.
Would you like this to go into ARM now?
Tom
> Regards..
> Prafulla . .
>
>> Tom
>>
next prev parent reply other threads:[~2010-03-05 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 9:57 [U-Boot] [PATCH] arm: kirkwood: suen3: fixed build warning Prafulla Wadaskar
2010-03-04 13:55 ` Tom
2010-03-05 5:14 ` Prafulla Wadaskar
2010-03-05 14:18 ` Tom [this message]
2010-03-06 17:07 ` Prafulla Wadaskar
2010-03-06 20:17 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9112CC.9020302@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.