All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@redhat.com>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	"Arnaldo Carvalho de Melo" <acme@redhat.com>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Mike Galbraith" <efault@gmx.de>,
	"Peter Zijlstra" <a.p.zijlstra@chello.nl>,
	"Paul Mackerras" <paulus@samba.org>
Subject: Re: [PATCH 1/6] perf probe: Add missing variable initialization
Date: Fri, 05 Mar 2010 11:01:45 -0500	[thread overview]
Message-ID: <4B912AE9.90603@redhat.com> (raw)
In-Reply-To: <1267804269-22660-1-git-send-email-acme@infradead.org>

Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> cc1: warnings being treated as errors
> util/probe-finder.c: In function ‘find_line_range’:
> util/probe-finder.c:172: warning: ‘src’ may be used uninitialized in this function
> make: *** [util/probe-finder.o] Error 1

Acked-by: Masami Hiramatsu <mhiramat@redhat.com>

Thank you!

> 
> Cc: Frédéric Weisbecker <fweisbec@gmail.com>
> Cc: Masami Hiramatsu <mhiramat@redhat.com>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/util/probe-finder.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index e77dc88..1e6c65e 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -169,7 +169,7 @@ static const char *cu_find_realpath(Dwarf_Die *cu_die, const char *fname)
>  {
>  	Dwarf_Files *files;
>  	size_t nfiles, i;
> -	const char *src;
> +	const char *src = NULL;
>  	int ret;
>  
>  	if (!fname)

-- 
Masami Hiramatsu
e-mail: mhiramat@redhat.com

      parent reply	other threads:[~2010-03-05 16:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05 15:51 [PATCH 1/6] perf probe: Add missing variable initialization Arnaldo Carvalho de Melo
2010-03-05 15:51 ` [PATCH 2/6] perf record: Add ID and to recorded event data when recording multiple events Arnaldo Carvalho de Melo
2010-03-10 13:14   ` [tip:perf/urgent] " tip-bot for Eric B Munson
2010-03-05 15:51 ` [PATCH 3/6] perf session: Change add_hist_entry to take the tree root instead of session Arnaldo Carvalho de Melo
2010-03-10 13:14   ` [tip:perf/urgent] " tip-bot for Eric B Munson
2010-03-05 15:51 ` [PATCH 4/6] perf session: Add storage for seperating event types in report Arnaldo Carvalho de Melo
2010-03-10 13:14   ` [tip:perf/urgent] " tip-bot for Eric B Munson
2010-03-05 15:51 ` [PATCH 5/6] perf session: Change perf_session post processing functions to take histogram tree Arnaldo Carvalho de Melo
2010-03-10 13:15   ` [tip:perf/urgent] " tip-bot for Eric B Munson
2010-03-05 15:51 ` [PATCH 6/6] perf report: Add multiple event support Arnaldo Carvalho de Melo
2010-03-10 13:15   ` [tip:perf/urgent] " tip-bot for Eric B Munson
2010-03-05 16:01 ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B912AE9.90603@redhat.com \
    --to=mhiramat@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=efault@gmx.de \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.