From: Takahiro Yasui <tyasui@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 10 of 10] LVM: rework lvconvert_mirrorsuil
Date: Mon, 08 Mar 2010 00:54:35 -0500 [thread overview]
Message-ID: <4B94911B.8030707@redhat.com> (raw)
In-Reply-To: <201003052359.o25Nxeg5012728@hydrogen.msp.redhat.com>
Jonathan Brassow wrote:
> +static int _lvconvert_mirrors_aux(struct cmd_context *cmd,
> + struct logical_volume *lv,
> + struct lvconvert_params *lp,
> + struct dm_list *operable_pvs,
> + uint32_t new_mimage_count,
> + uint32_t new_log_count,
> + int allocation_failures_ok)
> +{
> + uint32_t region_size;
> + struct lv_segment *seg;
...
> + /* Insert a temporary layer for syncing,
> + * only if the original lv is using disk log. */
> + if (seg->log_lv && !_insert_lvconvert_layer(cmd, lv)) {
> + log_error("Failed to insert resync layer");
> + return 0;
> + }
"seg" seems to be used uninitialized here.
> +static int _lvconvert_mirrors_orig(struct cmd_context *cmd,
> + struct logical_volume *lv,
> + struct lvconvert_params *lp)
> +{
This function is not used anywhere...
Thanks,
Taka
prev parent reply other threads:[~2010-03-08 5:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 23:59 [PATCH 10 of 10] LVM: rework lvconvert_mirrors Jonathan Brassow
2010-03-08 5:33 ` Takahiro Yasui
2010-03-08 5:54 ` Takahiro Yasui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B94911B.8030707@redhat.com \
--to=tyasui@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.