From: Eamon Walsh <ewalsh@tycho.nsa.gov>
To: KaiGai Kohei <kaigai@ak.jp.nec.com>
Cc: selinux@tycho.nsa.gov, Joshua Brindle <jbrindle@tresys.com>
Subject: Re: [PATCH] libselinux: fix avc_netlink_loop() error caused by nonblocking mode.
Date: Mon, 08 Mar 2010 18:19:00 -0500 [thread overview]
Message-ID: <4B9585E4.8040203@tycho.nsa.gov> (raw)
In-Reply-To: <4B8DAD9A.5020200@ak.jp.nec.com>
On 03/02/2010 07:30 PM, KaiGai Kohei wrote:
>
> It seems to me ok basically.
>
> It is just my preference. Can you move the poll(2) at the head of
> the avc_netlink_receive() call, like as the attachment?
> How should I say...it seems to me itchy to change non-blocking mode
> into blocking mode implicitly at avc_netlink_loop(), although we can
> specify the mode at creation time (avc_netlink_open()).
>
> Thanks,
>
I have pushed this patch, thanks.
--
Eamon Walsh
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2010-03-08 23:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-03 6:19 avc_open() and netlink_loop() KaiGai Kohei
2010-02-26 19:14 ` Eamon Walsh
2010-02-26 20:49 ` Eamon Walsh
2010-02-26 20:56 ` [PATCH] libselinux: fix avc_netlink_loop() error caused by nonblocking mode Eamon Walsh
2010-03-02 2:48 ` KaiGai Kohei
2010-03-02 17:29 ` Eamon Walsh
2010-03-03 0:30 ` KaiGai Kohei
2010-03-08 23:19 ` Eamon Walsh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9585E4.8040203@tycho.nsa.gov \
--to=ewalsh@tycho.nsa.gov \
--cc=jbrindle@tresys.com \
--cc=kaigai@ak.jp.nec.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.