All of lore.kernel.org
 help / color / mirror / Atom feed
From: KaiGai Kohei <kaigai@ak.jp.nec.com>
To: Joshua Roys <joshua.roys@gtri.gatech.edu>
Cc: "selinux@tycho.nsa.gov" <selinux@tycho.nsa.gov>
Subject: Re: [RFC][PATCH] mod_selinux: setcon earlier
Date: Tue, 09 Mar 2010 10:02:55 +0900	[thread overview]
Message-ID: <4B959E3F.2030700@ak.jp.nec.com> (raw)
In-Reply-To: <4B956AA9.4040004@gtri.gatech.edu>

(2010/03/09 6:22), Joshua Roys wrote:
> On 03/08/2010 01:42 AM, KaiGai Kohei wrote:
>>> The current code ends up calling setcon after sockets have been opened,
> ...
>>> noticed issues with labeled networking having the setcon() called after
>>> the listening sockets are opened.
>>
>> Hmm. The purpose of selinuxServerDomain allows to drop unnecessary
>> categories on the starting up time, although mod_selinux.pp set it
>> to translate into 's0 - mcs_systemhigh'. So, the listener sockets
>> also should be created in the configured domain.
>> It seems to me what you pointed out is fair enough.
>>
>> However, I cannot agree to change security context of the server
>> which it parses the configuration file, because we can call setcon()
>> in the open_logs hook earlier than listener sockets are created using
>> APR_HOOK_FIRST, not APR_HOOK_MIDDLE.
>>
>> Thanks,
>>
> 
> Hello,
> 
> Do you mean instead of mod_selinux hooking post_config, it would now
> hook open_logs?  If so, I think you would have to use something like:
> (APR_HOOK_REALLY_FIRST-1), because prefork.c hooks open_logs using
> REALLY_FIRST...

Yes, not only prefork, all the supported MPM engine does it in this manner.
As long as we are in apache/httpd-2.2.x series, this hack will be needed.

In the upcoming apache/httpd-2.4.x series, it allows to implement MPM
engine with actually loadable module, so we will be able to avoid this
kind of hacks with multi processing behavior suitable for selinux...

Thanks,
-- 
KaiGai Kohei <kaigai@ak.jp.nec.com>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

      reply	other threads:[~2010-03-09  1:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-05 21:46 [RFC][PATCH] mod_selinux: setcon earlier Joshua Roys
2010-03-08  6:42 ` KaiGai Kohei
2010-03-08 21:22   ` Joshua Roys
2010-03-09  1:02     ` KaiGai Kohei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B959E3F.2030700@ak.jp.nec.com \
    --to=kaigai@ak.jp.nec.com \
    --cc=joshua.roys@gtri.gatech.edu \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.