From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code.
Date: Tue, 09 Mar 2010 14:51:42 +0300 [thread overview]
Message-ID: <4B96364E.5050202@mvista.com> (raw)
In-Reply-To: <f861ec6f1003090345n53570102je68aef14e8b3f3fb@mail.gmail.com>
Manuel Lauss wrote:
>>> Where it really belongs to.
>> I disagree (again). SoC platform devices dont belong with the board code.
>>
>
> Figured as much. However with additional boards the #ifdef mess in
> common/platform.c
> is only going to get worse. MUCH worse.
We could probably eliminate the board #ifdef in platfrom.c by not
supplying the platfrom data for MMC1.
> Just look at the au1000-eth platform data situation!
> I have these platform devices on Au1200/Au1300 even thought they don't have
> a built-in MAC.
>
Need to add the SoC type checks then when registering the devices. Or
at least the #ifdef's. :-)
> The board which uses the device should register it.
Contrarywise, the SoC that has the devices, should register them.
> But, consider the patch withdrawn.
>
Thanks.
> Manuel
>
WBR, Sergei
next prev parent reply other threads:[~2010-03-09 11:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 19:22 [PATCH] MIPS: Alchemy: sleepcode without compile-time cputype dependencies Manuel Lauss
2010-03-08 19:23 ` [RFC PATCH] MIPS: Alchemy: add sysdev for both irq controllers Manuel Lauss
2010-03-10 16:13 ` Ralf Baechle
2010-03-10 19:03 ` Manuel Lauss
2010-03-08 19:23 ` [PATCH] MIPS: Alchemy: move MMC driver registration to board code Manuel Lauss
2010-03-09 11:33 ` Sergei Shtylyov
2010-03-09 11:45 ` Manuel Lauss
2010-03-09 11:45 ` Manuel Lauss
2010-03-09 11:51 ` Sergei Shtylyov [this message]
2010-03-09 12:03 ` Manuel Lauss
2010-03-09 12:03 ` Manuel Lauss
2010-03-10 16:48 ` Ralf Baechle
2010-03-10 18:34 ` Manuel Lauss
2010-03-10 18:34 ` Manuel Lauss
2010-03-10 16:04 ` [PATCH] MIPS: Alchemy: sleepcode without compile-time cputype dependencies Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B96364E.5050202@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.