From: Eamon Walsh <ewalsh@tycho.nsa.gov>
To: KaiGai Kohei <kaigai@kaigai.gr.jp>
Cc: Andy Warner <warner@rubix.com>, selinux@tycho.nsa.gov
Subject: Re: [PATCH] libselinux: selabel_*() support for database objects
Date: Wed, 10 Mar 2010 12:11:44 -0500 [thread overview]
Message-ID: <4B97D2D0.3010507@tycho.nsa.gov> (raw)
In-Reply-To: <4B96C8CA.1090301@kaigai.gr.jp>
On 03/09/2010 05:16 PM, KaiGai Kohei wrote:
> (2010/03/10 5:08), Eamon Walsh wrote:
>
>> What is the meaning of the fourth "temp" argument here. Aren't lines
>> only supposed to have three entries? Please remove this if it is not needed.
>>
> If the line has four or more elements, we want to raise an error, rather than
> ignoring it.
> If here is not the fourth %as, sscanf() does not return 4, does it?
>
> Thanks,
>
OK, that makes sense.
I don't see any other issues with the patches. Unless Andy has any
concerns, I will push them later today or tomorrow.
--
Eamon Walsh
National Security Agency
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2010-03-10 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 8:21 [PATCH] libselinux: selabel_*() support for database objects KaiGai Kohei
2009-11-21 3:01 ` Eamon Walsh
2009-11-21 14:16 ` KaiGai Kohei
2009-11-25 23:29 ` KaiGai Kohei
2009-11-30 21:30 ` Eamon Walsh
2010-03-02 2:53 ` KaiGai Kohei
2010-03-08 23:13 ` Eamon Walsh
2010-03-08 23:26 ` Andy Warner
2010-03-08 23:34 ` KaiGai Kohei
2010-03-09 0:40 ` KaiGai Kohei
2010-03-09 1:22 ` Eamon Walsh
2010-03-09 1:42 ` KaiGai Kohei
2010-03-09 20:08 ` Eamon Walsh
2010-03-09 22:16 ` KaiGai Kohei
2010-03-10 17:11 ` Eamon Walsh [this message]
2010-03-10 18:04 ` Andy Warner
2010-03-11 4:28 ` KaiGai Kohei
2010-03-12 1:05 ` KaiGai Kohei
2010-03-15 23:13 ` Eamon Walsh
2010-03-16 0:01 ` KaiGai Kohei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B97D2D0.3010507@tycho.nsa.gov \
--to=ewalsh@tycho.nsa.gov \
--cc=kaigai@kaigai.gr.jp \
--cc=selinux@tycho.nsa.gov \
--cc=warner@rubix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.