From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NpRm2-0000Kw-BO for qemu-devel@nongnu.org; Wed, 10 Mar 2010 14:40:54 -0500 Received: from [199.232.76.173] (port=34064 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NpRm1-0000KG-Hc for qemu-devel@nongnu.org; Wed, 10 Mar 2010 14:40:53 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NpRly-00040G-Uf for qemu-devel@nongnu.org; Wed, 10 Mar 2010 14:40:53 -0500 Received: from sj-iport-1.cisco.com ([171.71.176.70]:30927) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1NpRly-0003zg-IR for qemu-devel@nongnu.org; Wed, 10 Mar 2010 14:40:50 -0500 Message-ID: <4B97F5BC.5050500@cisco.com> Date: Wed, 10 Mar 2010 12:40:44 -0700 From: "David S. Ahern" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] hw/usb-msd: fix some usb requests References: <87pr3cmrx3.fsf@lechat.rtp-net.org> In-Reply-To: <87pr3cmrx3.fsf@lechat.rtp-net.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Arnaud Patard (Rtp)" Cc: qemu-devel@nongnu.org On 03/10/2010 02:45 AM, Arnaud Patard (Rtp) wrote: > > The usb-msd device emulation needs some small tweaks in the requests > emulations. For instance, the reset/maxlun requests are class/interface > specific so requests for them with the type class and recipient interface > bits sets have to be handled. > > Signed-off-by: Arnaud Patard > --- I hit this yesterday with msd as well. I suggest moving the ClassInterfaceRequest and ClassInterfaceOutRequest defines from hw/usb-net.c to hw/usb.h and then use those in hw/usb-msd.c for the Class specific requests. David