From: Yinghai Lu <yinghai@kernel.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH 5/6] early_res: seperate common memmap func from e820.c to fw_memmap.c
Date: Wed, 10 Mar 2010 15:59:38 -0800 [thread overview]
Message-ID: <4B98326A.1020905@kernel.org> (raw)
In-Reply-To: <20100310234620.GA3897@brick.ozlabs.ibm.com>
On 03/10/2010 03:46 PM, Paul Mackerras wrote:
> On Wed, Mar 10, 2010 at 01:24:26PM -0800, Yinghai Lu wrote:
>
>> move it to kernel/fw_memmap.c from arch/x86/kernel/e820.c
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>>
>> ---
>> arch/x86/include/asm/e820.h | 130 -----
>> arch/x86/kernel/e820.c | 1142 --------------------------------------------
>> include/linux/bootmem.h | 2
>> include/linux/fw_memmap.h | 114 ++++
>> kernel/Makefile | 2
>> kernel/fw_memmap.c | 1134 +++++++++++++++++++++++++++++++++++++++++++
>
> Yuck. So you think we should use > 1100 lines of fw_memmap.c code
> instead of the 541 lines of lib/lmb.c? Why exactly would that be
> better?
>
even worse
you should count
early_res + fw_memmap
YH
next prev parent reply other threads:[~2010-03-11 0:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 21:24 [PATCH -v2 0/6] early_res: fw_memmap.c Yinghai Lu
2010-03-10 21:24 ` [PATCH 1/4] x86: add get_centaur_ram_top Yinghai Lu
2010-03-10 21:24 ` [PATCH 2/4] x86: make e820 to be static Yinghai Lu
2010-03-10 21:24 ` [PATCH 3/4] x86: use wake_system_ram_range instead of e820_any_mapped in agp path Yinghai Lu
2010-03-10 21:24 ` [PATCH 4/4] x86: make e820 to be initdata Yinghai Lu
2010-03-10 21:24 ` [PATCH 5/6] early_res: seperate common memmap func from e820.c to fw_memmap.c Yinghai Lu
2010-03-10 21:50 ` Russell King
2010-03-10 21:55 ` David Miller
2010-03-10 22:05 ` Yinghai Lu
2010-03-10 22:05 ` Yinghai Lu
2010-03-10 23:46 ` Paul Mackerras
2010-03-10 23:59 ` Yinghai Lu [this message]
2010-03-10 21:24 ` [RFC PATCH 6/6] sparc64: use early_res and nobootmem Yinghai Lu
2010-03-10 21:30 ` David Miller
2010-03-10 21:33 ` David Miller
2010-03-10 21:34 ` Yinghai Lu
2010-03-10 21:36 ` David Miller
2010-03-10 22:10 ` Yinghai Lu
2010-03-10 22:17 ` David Miller
2010-03-10 22:31 ` Yinghai Lu
2010-03-10 22:36 ` David Miller
2010-03-10 23:01 ` Yinghai Lu
2010-03-10 23:47 ` Benjamin Herrenschmidt
2010-03-11 0:02 ` Yinghai Lu
2010-03-11 3:59 ` Paul Mundt
2010-03-10 22:04 ` David Miller
2010-03-10 22:20 ` Yinghai Lu
2010-03-10 22:49 ` David Miller
2010-03-10 23:05 ` Yinghai Lu
2010-03-10 23:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B98326A.1020905@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.