From: Yang Shi <yang.shi@windriver.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: ddaney@caviumnetworks.com, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c
Date: Thu, 11 Mar 2010 10:53:44 +0800 [thread overview]
Message-ID: <4B985B38.1050105@windriver.com> (raw)
In-Reply-To: <20100309191750.GA1960@linux-mips.org>
Ralf Baechle 写道:
> On Tue, Mar 09, 2010 at 08:03:09PM +0100, Ralf Baechle wrote:
>
>
>>> @@ -281,7 +281,7 @@ static void octeon_cpu_die(unsigned int cpu)
>>>
>>> #ifdef CONFIG_CAVIUM_OCTEON_WATCHDOG
>>> /* Disable the watchdog */
>>> - cvmx_ciu_wdogx_t ciu_wdog;
>>> + union cvmx_ciu_wdogx ciu_wdog;
>>> ciu_wdog.u64 = cvmx_read_csr(CVMX_CIU_WDOGX(cpu));
>>> ciu_wdog.s.mode = 0;
>>> cvmx_write_csr(CVMX_CIU_WDOGX(cpu), ciu_wdog.u64);
>>>
>> David,
>>
>> I think this ifdef should be replaced by a notifier called from
>> __cpu_die().
>>
>
> Since this is unused I'll just remove it for now.
>
This breaks kernel build when HOTPLUG_CPU is enabled.
Regards,
Yang
> Ralf
>
>
prev parent reply other threads:[~2010-03-11 2:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 6:24 [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c Yang Shi
2010-03-09 19:03 ` Ralf Baechle
2010-03-09 19:17 ` Ralf Baechle
2010-03-11 2:53 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B985B38.1050105@windriver.com \
--to=yang.shi@windriver.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.