From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
uril@redhat.com, qemu-devel@nongnu.org,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3]: BLOCK_WATERMARK QMP event
Date: Thu, 11 Mar 2010 09:07:04 -0600 [thread overview]
Message-ID: <4B990718.90409@codemonkey.ws> (raw)
In-Reply-To: <4B990507.5090101@redhat.com>
On 03/11/2010 08:58 AM, Avi Kivity wrote:
> On 03/11/2010 04:19 PM, Anthony Liguori wrote:
>>
>>> But honestly, while I do understand your point, this feels like a hack
>>> to work around shortcomings of an interface. So what we need to decide
>>> is which criterion outweighs the other in practice.
>>
>> If I understand the use case correctly, what this really boils down
>> to is that you want to create a growable image on top of a
>> non-growable device. The management tool then deals with growth
>> using this interface.
>>
>> I'm somewhat inclined to suggest that the proper way to support this
>> is to teach qemu how to grow the LVM volume like it would grow any
>> normal file.
>
> Interesting. Could use a helper or helper.so, or a new block format
> driver (block/lvm.c).
I've suggested plugins for the block drivers in the past. I don't think
it was well received.
> Still, if management is actually interested in the change, not just
> to grow the volume (perhaps to handle out-of-space, or to check
> against a global disk low condition), the helper/driver then needs to
> communicate with the management system, which is awkward.
The management system can poll information from the block driver.
Polling is not always evil :-)
Regards,
Anthony Liguori
>
> I guess it's workable though.
>
next prev parent reply other threads:[~2010-03-11 15:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 22:53 [Qemu-devel] [PATCH 0/3]: BLOCK_WATERMARK QMP event Luiz Capitulino
2010-03-09 22:53 ` [Qemu-devel] [PATCH 1/3] block-qcow2: keep highest allocated offset Luiz Capitulino
2010-03-09 22:53 ` [Qemu-devel] [PATCH 2/3] monitor: Introduce block_watermark command Luiz Capitulino
2010-03-09 22:53 ` [Qemu-devel] [PATCH 3/3] QMP: Introduce BLOCK_WATERMARK event Luiz Capitulino
2010-03-09 23:03 ` [Qemu-devel] [PATCH 0/3]: BLOCK_WATERMARK QMP event Anthony Liguori
2010-03-09 23:18 ` Luiz Capitulino
2010-03-09 23:08 ` Anthony Liguori
2010-03-09 23:22 ` Luiz Capitulino
2010-03-09 23:25 ` Luiz Capitulino
2010-03-09 23:55 ` Anthony Liguori
2010-03-10 21:02 ` Luiz Capitulino
2010-03-09 23:46 ` Anthony Liguori
2010-03-10 8:40 ` Kevin Wolf
2010-03-10 21:09 ` Luiz Capitulino
2010-03-10 21:20 ` Anthony Liguori
2010-03-11 8:34 ` Kevin Wolf
2010-03-11 14:19 ` Anthony Liguori
2010-03-11 14:58 ` Avi Kivity
2010-03-11 15:07 ` Anthony Liguori [this message]
2010-03-11 15:09 ` Avi Kivity
2010-03-11 16:16 ` Kevin Wolf
2010-03-10 8:33 ` [Qemu-devel] " Kevin Wolf
2010-03-10 9:28 ` Christoph Hellwig
2010-03-10 21:11 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B990718.90409@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.