All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] migration: unix migration should obey autostart are the other ones
Date: Thu, 11 Mar 2010 14:27:51 -0600	[thread overview]
Message-ID: <4B995247.5010306@codemonkey.ws> (raw)
In-Reply-To: <df010a71b58fcd4ae080fed1652daef2a74b1ec2.1268176134.git.quintela@redhat.com>

On 03/09/2010 05:10 PM, Juan Quintela wrote:
> This was the only incoming migration without autostart check
>
> Signed-off-by: Juan Quintela<quintela@redhat.com>
> ---
>   migration-unix.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/migration-unix.c b/migration-unix.c
> index ce59a2a..49de1b9 100644
> --- a/migration-unix.c
> +++ b/migration-unix.c
> @@ -176,6 +176,8 @@ static void unix_accept_incoming_migration(void *opaque)
>       qemu_announce_self();
>       DPRINTF("successfully loaded vm state\n");
>
> +    if (autostart)
> +        vm_start();
>    

Maybe a better thing to do is make accept_incoming_migration return an 
error code and do the vm_start in common code.

Regards,

Anthony Liguori

>   out_fopen:
>       qemu_fclose(f);
>    

  reply	other threads:[~2010-03-11 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-09 23:10 [Qemu-devel] [PATCH 0/2] Migration fixes Juan Quintela
2010-03-09 23:10 ` [Qemu-devel] [PATCH 1/2] migration: Clear fd also in error cases Juan Quintela
2010-03-17 16:57   ` Anthony Liguori
2010-03-09 23:10 ` [Qemu-devel] [PATCH 2/2] migration: unix migration should obey autostart are the other ones Juan Quintela
2010-03-11 20:27   ` Anthony Liguori [this message]
2010-03-11 20:42     ` [Qemu-devel] " Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B995247.5010306@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.