Re: [PATCH/RFC] zlib: convert to BBCLASSEXTEND

[Scott Garman <sgarman@zenlinux.com>]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On 03/11/2010 04:18 PM, Khem Raj wrote:
> Thanks for the patch. While this change looks ok. You should submit a full patch
> where you also delete the unneeded recipes and with proper sign-off
>
> http://wiki.openembedded.net/index.php/Commit_Policy
> http://wiki.openembedded.net/index.php/Commit_log_example
>
> might help
>
> and also formatting patch with git format-patch would be nice.

Gotcha, thanks for the feedback. Let's try this then. In the future I 
assume the format-patch email should be sent directly to the list and 
not as an attachment - correct me if I'm mistaken.

Scott

-- 
Scott Garman
sgarman at zenlinux dot com

[-- Attachment #2: 0001-zlib-convert-to-new-style-staging-and-BBCLASSEXTEND.patch --]
[-- Type: text/x-patch, Size: 1658 bytes --]

From 322589252447f6bb4a96b79b5495001f6cb64f12 Mon Sep 17 00:00:00 2001
From: Scott Garman <sgarman@zenlinux.com>
Date: Thu, 11 Mar 2010 19:15:29 -0800
Subject: [PATCH] zlib: convert to new style staging and BBCLASSEXTEND

---
 recipes/zlib/zlib-native_1.2.3.bb |    5 -----
 recipes/zlib/zlib-sdk_1.2.3.bb    |    4 ----
 recipes/zlib/zlib_1.2.3.bb        |    6 ++----
 3 files changed, 2 insertions(+), 13 deletions(-)
 delete mode 100644 recipes/zlib/zlib-native_1.2.3.bb
 delete mode 100644 recipes/zlib/zlib-sdk_1.2.3.bb

diff --git a/recipes/zlib/zlib-native_1.2.3.bb b/recipes/zlib/zlib-native_1.2.3.bb
deleted file mode 100644
index d7e0777..0000000
--- a/recipes/zlib/zlib-native_1.2.3.bb
+++ /dev/null
@@ -1,5 +0,0 @@
-require zlib_${PV}.bb
-ZLIB_EXTRA = ""
-DEPENDS = "libtool-native"
-
-inherit native
diff --git a/recipes/zlib/zlib-sdk_1.2.3.bb b/recipes/zlib/zlib-sdk_1.2.3.bb
deleted file mode 100644
index 4863395..0000000
--- a/recipes/zlib/zlib-sdk_1.2.3.bb
+++ /dev/null
@@ -1,4 +0,0 @@
-require zlib_${PV}.bb
-LIB_EXTRA = ""
-
-inherit sdk
diff --git a/recipes/zlib/zlib_1.2.3.bb b/recipes/zlib/zlib_1.2.3.bb
index d995869..db4b16b 100644
--- a/recipes/zlib/zlib_1.2.3.bb
+++ b/recipes/zlib/zlib_1.2.3.bb
@@ -3,7 +3,7 @@ SECTION = "libs"
 PRIORITY = "required"
 HOMEPAGE = "http://www.gzip.org/zlib/"
 LICENSE = "zlib"
-PR ="r5"
+PR ="r6"
 
 SRC_URI = "http://www.zlib.net/zlib-1.2.3.tar.bz2 \
 		file://visibility.patch;patch=1 \
@@ -15,6 +15,4 @@ DEPENDS = "libtool-cross"
 
 inherit autotools
 
-do_stage() {
-	autotools_stage_all
-}
+BBCLASSEXTEND = "native sdk"
-- 
1.6.3.3