From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nq4yv-00038O-2F
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:32:49 -0500
Received: from [199.232.76.173] (port=50887 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nq4yu-00038G-Kt
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:32:48 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <aurelien@aurel32.net>) id 1Nq4yt-00083i-Bp
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:32:48 -0500
Received: from hall.aurel32.net ([88.191.82.174]:51669)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1Nq4yt-00083O-2f
	for qemu-devel@nongnu.org; Fri, 12 Mar 2010 08:32:47 -0500
Message-ID: <4B9A4272.2000102@aurel32.net>
Date: Fri, 12 Mar 2010 14:32:34 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
MIME-Version: 1.0
References: <a38b25541003120338l54f1f12fq3afde9424ed76955@mail.gmail.com>
	<4B9A4003.9030908@redhat.com>
In-Reply-To: <4B9A4003.9030908@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] Re: [PATCH] target-i386: fix commit
	c22549204a6edc431e8e4358e61bd56386ff6957
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: TeLeMan <geleman@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

Paolo Bonzini a écrit :
> On 03/12/2010 12:38 PM, TeLeMan wrote:
>> The commit c22549204a6edc431e8e4358e61bd56386ff6957 led movntps&
>> movntdq to be translated incorrectly.
> 
> This should go on stable-0.12 too.
> 


The patch is correct, and I agree it should go to stable-0.12 too. I'll
commit it later today.

> 
>> Signed-off-by: TeLeMan<geleman@gmail.com>
>> ---
>>   target-i386/translate.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/target-i386/translate.c b/target-i386/translate.c
>> index 6838d53..07b0a70 100644
>> --- a/target-i386/translate.c
>> +++ b/target-i386/translate.c
>> @@ -3457,6 +3457,11 @@ static void gen_sse(DisasContext *s, int b,
>> target_ulong pc_start, int rex_r)
>>           case 0x1e7: /* movntdq */
>>           case 0x02b: /* movntps */
>>           case 0x12b: /* movntps */
>> +            if (mod == 3)
>> +                goto illegal_op;
>> +            gen_lea_modrm(s, modrm,&reg_addr,&offset_addr);
>> +            gen_sto_env_A0(s->mem_index, offsetof(CPUX86State,xmm_regs[reg]));
>> +            break;
>>           case 0x3f0: /* lddqu */
>>               if (mod == 3)
>>                   goto illegal_op;
> 
> 


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net