From: Takahiro Yasui <tyasui@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix segfault when destroying in-use filters in pvs -a.
Date: Fri, 12 Mar 2010 11:56:51 -0500 [thread overview]
Message-ID: <4B9A7253.3010201@redhat.com> (raw)
In-Reply-To: <4B994B10.9080409@redhat.com>
Milan,
On 03/11/10 14:57, Takahiro Yasui wrote:
> On 03/10/10 16:43, Milan Broz wrote:
>> Because pvs -a iterate throught the whole device cache
>> we should not refresh filters inside iteration.
>>
>> Fix it by introducing simple reference counter and test
>> it in refresh_filters() call.
>>
>> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=571963
This patch worked fine in my test case, but I have one question about
your patch. I assume that you added refresh_filters() because it was
necessary, but this patch prevents filter from being refreshed if it
is in use.
Don't we need to refresh the filter when in_use flag is decremented
and becomes 0 after or in dev_iter_destroy()?
Thanks,
Taka
next prev parent reply other threads:[~2010-03-12 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 21:43 [PATCH] Fix segfault when destroying in-use filters in pvs -a Milan Broz
2010-03-11 19:57 ` Takahiro Yasui
2010-03-12 16:56 ` Takahiro Yasui [this message]
2010-03-15 10:37 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9A7253.3010201@redhat.com \
--to=tyasui@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.