From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Nqn0C-0007p3-PY for mharc-grub-devel@gnu.org; Sun, 14 Mar 2010 08:33:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nqn09-0007oA-Pg for grub-devel@gnu.org; Sun, 14 Mar 2010 08:33:01 -0400 Received: from [140.186.70.92] (port=54591 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nqn08-0007nN-84 for grub-devel@gnu.org; Sun, 14 Mar 2010 08:33:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nqn06-0001D9-MO for grub-devel@gnu.org; Sun, 14 Mar 2010 08:33:00 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:35495) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nqn06-0001D1-HN for grub-devel@gnu.org; Sun, 14 Mar 2010 08:32:58 -0400 Received: by bwz19 with SMTP id 19so2541564bwz.26 for ; Sun, 14 Mar 2010 05:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=5tZYV7P/eTxJbP1S71jp0lqclGTm+120nRj6mUFS2ss=; b=SOHkgycYonS6UdOllIFyxSL4l2By20UFMWRKRQVUA13xM1JkiSpccFXN1sJibjEkis lpsKnozPHj7rKiVvXywN3fDjd80SvMsRjI9c67gJxdcITaZ9zYWoQqbyhYK3+0+x1Sms m+Wq/aag7KHgU2oqVti06t3xs/9SGJyoEpk7M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=azfrtTp3WBlL4BTdhDIywMfGh3FdPrW1fHQRvDtDEJqfJ6wpsHMDzAdZibtisS3ZjS ZWv+faziEJcgqPl4V1JjkRhJpIIjNG4si+5pDXU94y5mIFF/h5W0vfl+gob8g0K8mXXM 3hvvq6j+l6wZwMOilmDYx5tSWFMMbPRGzDgYE= Received: by 10.204.7.203 with SMTP id e11mr5613327bke.39.1268569976671; Sun, 14 Mar 2010 05:32:56 -0700 (PDT) Received: from debian.bg45.phnet (74.101.202.62.cust.bluewin.ch [62.202.101.74]) by mx.google.com with ESMTPS id 16sm2105981bwz.9.2010.03.14.05.32.53 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 14 Mar 2010 05:32:54 -0700 (PDT) Message-ID: <4B9CD76E.8020102@gmail.com> Date: Sun, 14 Mar 2010 13:32:46 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <87aaug8iw0.wl%jir@sekiba.com> <4B979915.8020203@gmail.com> <8763545kvt.wl%jir@sekiba.com> In-Reply-To: <8763545kvt.wl%jir@sekiba.com> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig66CB71B72370CCB311EA96A3" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: How can I use grub_getcrc32 in fs module X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2010 12:33:02 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig66CB71B72370CCB311EA96A3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jiro SEKIBA wrote: >> Filesystem modules are often size-constrained. So we skip the >> consistency checks unless they are inherent part of filesystem operati= on. >> If filesystem is corrupted there isn't much we can do other than hope >> that boot-related files aren't affected. GRUB itself never writes to f= s >> metadata so it won't lead to any additional corruption >> =20 > > Ah, I see. Ok, then we may skip checking super block crc. > =20 Skipping only part of crc checks doesn't bring anything. > However, becuase of nature of nilfs2, a log file system, > I need to roll forward the logs to find the latest log > in case that super block does not point appropriate latest log > on unclean unmounting. > > In the forwarding process, log is verified by crc. > > =20 In this case ok. Can you make tests and compare the size with either using lib/crc.c or CRC32 from crypto framework? This is something that would justify keeping lib/crc.c despite my previous plans on its removal if the difference is significant. >>> I added lib/crc.c in SOURCES in common.rmk for the fs module. >>> It looks OK to compile the target fs module. >>> However I got following link error for grub-setup and grub-probe. >>> >>> grub_setup-fs_nilfs2.o: In function `grub_nilfs2_valid_sb': >>> nilfs2.c:(.text+0xe29): undefined reference to `grub_getcrc32' >>> nilfs2.c:(.text+0xe47): undefined reference to `grub_getcrc32' >>> nilfs2.c:(.text+0xe7e): undefined reference to `grub_getcrc32' >>> collect2: ld returned 1 exit status >>> >>> I was trying to specify lib/crc.c in grub_setup_SOURCES, but got same= result. >>> >>> =20 >>> =20 >> Stupid question: have you rerun ./autogen.sh ? >> =20 > > Yes, I did. I should have mentioned. > What I did is > > sh autogen.sh > make clean;./configure;make > > =20 May I have a look at this part of the patch? --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig66CB71B72370CCB311EA96A3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAkuc13QACgkQNak7dOguQgkoWwEAtakm7LAsxWNFvuibNRovNqm/ bHvD8x+gq2Lzzl97y/kBAKdLENQTEWPdDal1f34hzBQNWG1K/Vk99XIVWQ+1kzhv =b9l3 -----END PGP SIGNATURE----- --------------enig66CB71B72370CCB311EA96A3--