All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] -fda fat:dir -snapshot
Date: Mon, 15 Mar 2010 11:23:38 +0100	[thread overview]
Message-ID: <4B9E0AAA.3090307@redhat.com> (raw)
In-Reply-To: <4B9BE4F1.6030202@msgid.tls.msk.ru>

Am 13.03.2010 20:18, schrieb Michael Tokarev:
> Apparently this does not work, and for a loooong time:
> 
>  $ kvm -fda fat:dir
>  [ it opens the sdl window ]
>  $ kvm -fda fat:dir -snapshot
>  qemu: could not open disk image fat:dir: No such file or directory
> 
> Is it supposed to work?

Wow, that's a crazy case. I guess nobody has ever tested this, and
indeed it looks like it never has worked. As you might know, -snapshot
internally creates a temporary qcow2 image which takes the image you
originally asked for as a backing file.

So we have a qcow2 file with a backing file tmp:dir. Now, backing file
paths are always resolved relative to the COW file, so we get
/tmp/fat:dir. Oops.

We could just disable this for protocols as a quick fix, but I think in
fact you do want to have this behaviour when using protocols as a
backing file for a persistent COW image. I guess this needs some more
thought, especially in respect to the discussions of making
file/host_device/... protocols.

If you really have a use case for this, you can use an absolute path
after fat: as a workaround, it won't touch the path then.

Kevin

  reply	other threads:[~2010-03-15 10:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-13 19:18 [Qemu-devel] -fda fat:dir -snapshot Michael Tokarev
2010-03-15 10:23 ` Kevin Wolf [this message]
2010-03-15 14:20   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9E0AAA.3090307@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.