All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Naphtali Sprei <nsprei@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2 1/2] read-only: minor cleanup
Date: Mon, 15 Mar 2010 13:29:23 +0100	[thread overview]
Message-ID: <4B9E2823.8030107@redhat.com> (raw)
In-Reply-To: <1268572797-31664-1-git-send-email-nsprei@redhat.com>

On 03/14/2010 02:19 PM, Naphtali Sprei wrote:
> Really use read-only flags for opening the file when asked for read-only
>
> Signed-off-by: Naphtali Sprei<nsprei@redhat.com>
> ---
>   qemu-nbd.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index eac0c21..a393583 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -258,6 +258,7 @@ int main(int argc, char **argv)
>               break;
>           case 'r':
>               readonly = true;
> +            flags&= ~BDRV_O_RDWR;
>               break;
>           case 'P':
>               partition = strtol(optarg,&end, 0);

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

  reply	other threads:[~2010-03-15 12:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-14 13:19 [Qemu-devel] [PATCH v2 1/2] read-only: minor cleanup Naphtali Sprei
2010-03-15 12:29 ` Paolo Bonzini [this message]
2010-03-17 16:59 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9E2823.8030107@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=nsprei@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.