All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix pvcreate device check.
Date: Mon, 15 Mar 2010 14:18:17 +0100	[thread overview]
Message-ID: <4B9E3399.2020800@redhat.com> (raw)
In-Reply-To: <1268658848-24437-1-git-send-email-mbroz@redhat.com>


On 03/15/2010 02:14 PM, Milan Broz wrote:
> @@ -1294,17 +1294,9 @@ static int pvcreate_check(struct cmd_context *cmd, const char *name,
>  
>  	/* Is there an md superblock here? */
>  	if (!dev && md_filtering()) {
> -		unlock_vg(cmd, VG_ORPHANS);
> -
> -		persistent_filter_wipe(cmd->filter);
> -		lvmcache_destroy(cmd, 1);
> -
> +		refresh_filters(cmd);
>  		init_md_filtering(0);
> -		if (!lock_vol(cmd, VG_ORPHANS, LCK_VG_WRITE)) {
> -			log_error("Can't get lock for orphan PVs");
> -			init_md_filtering(1);
> -			return 0;
> -		}


> +		lvmcache_label_scan(cmd, 0);

even this rescan line is not needed, device must be in cache already,
just it is filtered out by MD filter.

Milan



  reply	other threads:[~2010-03-15 13:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-15 13:14 [PATCH] Fix pvcreate device check Milan Broz
2010-03-15 13:18 ` Milan Broz [this message]
2010-03-16 22:20   ` Dave Wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9E3399.2020800@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.