Re: [PATCH] linux-2.6.30: add linux4sam patches

[Nicolas Ferre <nicolas.ferre@atmel.com>]

Le 15/03/2010 13:46, Marcin Juszkiewicz :
> Dnia poniedziałek, 15 marca 2010 o 14:28:46 Nicolas Ferre napisał(a):
>> Marcin, what do you think of this patch architecture and URI management?
> 
> Nice. Few notes:
> 
> 1. do it all in linux_2.6.30.bb recipe

Ah? won't it be a too long recipe file for people not having to deal
with at91 ?

> 2. we rather user CAPS for variable names

OK.

> 3. AT91_SRC_URI = "contents of at91_kernel + contents of lnx4sam_exp3" would 
> be better

You mean:
AT91_SRC_URI = "${AT91_KERNEL} ${LNX4SAM_EXP3}"
and:
SRC_URI_at91sam9260ek = ${AT91_SRC_URI}
...
?

> 4. can't you just squash 2.6.30-at91-exp3.tar.gz into one patch?

I would like to keep a patch series in separated patches as this is what
is submitted and accepted during kernel development.
Keeping single patches, we can keep a patch archive and remove
individual ones from applying in a newer revision of the kernel.

>> The defconfig are not included in this patch and shall be sent in another
>> patch series.
> 
> Merge those into one patch - otherwise you will make "PR bump" flood.

Ok I will after the discussion settles...

Bye,
-- 
Nicolas Ferre