From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Lars Lindley <lindley@coyote.org>
Cc: Dan Carpenter <error27@gmail.com>,
gregkh@suse.de, greg@kroah.com, pavel@ucw.cz, diegoliz@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
stefanr@s5r6.in-berlin.de
Subject: Re: [PATCH] staging: winbond: mds.c whitspace, indentation etc.
Date: Mon, 15 Mar 2010 20:14:27 +0200 [thread overview]
Message-ID: <4B9E7903.30402@cs.helsinki.fi> (raw)
In-Reply-To: <4B9E6CA2.10602@coyote.org>
Lars Lindley wrote:
> On 2010-03-15 17:52, Pekka Enberg wrote:
>> Dan Carpenter wrote:
>>> On Mon, Mar 15, 2010 at 05:36:13PM +0100, Lars Lindley wrote:
>>>> I fixed most of the problems found by checkpatch.pl.
>>>> Some long lines are left and some KERN_..
>>>> This is a new revised patch against master with changes
>>>> after comments from Stefan Richter and Dan Carpenter.
>>>> Forget the old one.
>>>>
>>>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>>>> Acked-by: Pavel Machek <pavel@ucw.cz>
>>> Acked-by: Dan Carpenter <error27@gmail.com>
>> It's pretty difficult to say if anything changed based on the diff so
>> would you mind posting before and after output of 'size mds.o', please?
>>
> Hi Pekka.
>
> Before:
> lali@lazer2 ~/linux3/linux-2.6 $ size drivers/staging/winbond/mds.o
> text data bss dec hex filename
> 2804 0 0 2804 af4 drivers/staging/winbond/mds.o
>
> After:
> lali@lazer2 ~/linux2/linux-2.6 $ size drivers/staging/winbond/mds.o
> text data bss dec hex filename
> 2804 0 0 2804 af4 drivers/staging/winbond/mds.o
>
> diff:
> lali@lazer2 ~/linux2/linux-2.6 $ diff ../../linux3/linux-2.6/drivers/staging/winbond/mds.o drivers/staging/winbond/mds.o
> lali@lazer2 ~/linux2/linux-2.6 $
>
> linux3 is a clean tree and linux2 the one i'm working on..
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Greg, can you pick up my typedef cleanups and this patch to -staging?
next prev parent reply other threads:[~2010-03-15 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 16:36 [PATCH] staging: winbond: mds.c whitspace, indentation etc Lars Lindley
2010-03-15 16:50 ` Dan Carpenter
2010-03-15 16:52 ` Pekka Enberg
2010-03-15 17:21 ` Lars Lindley
2010-03-15 18:14 ` Pekka Enberg [this message]
2010-03-15 19:35 ` Greg KH
2010-03-15 20:12 ` Stefan Richter
2010-04-28 22:47 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-03-13 14:06 Lars Lindley
2010-03-13 14:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9E7903.30402@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=diegoliz@gmail.com \
--cc=error27@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.