From: Takahiro Yasui <tyasui@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 0 of 10] LVM: mirrored log patches
Date: Mon, 15 Mar 2010 22:37:05 -0400 [thread overview]
Message-ID: <4B9EEED1.5060606@redhat.com> (raw)
In-Reply-To: <1267833465.10315.3.camel@hydrogen.msp.redhat.com>
Jonathan Brassow wrote:
> There will likely be at least one more round of these patches - mostly
> to clean-up the last patch I've been working on.
>
> This round includes changes to the _lvconvert_mirrors function to allow
> it to handle the repair conversions necessary for 'lvconvert' to accept
> only top-level LVs. It also includes suggested changes from Taka
> (thanks for those!).
I checked your patch set. It seems that one of my suggestion has not
been implemented yet, and some of my tests failed.
https://www.redhat.com/archives/lvm-devel/2010-February/msg00214.html
In this patch set, _lvconvert_mirrors_aux() repairs in the order
of mirror images and mirror log. As I explained in the above url,
mirror log should be repaired before mirror images are repaired
because the repair procedure of the mirror image calls suspend_lv()
and that causes deadlock. The deadlock happens because suspending
LV with failed log device doesn't finish.
What do you think calling _lv_update_log_type() before and after
repairing mirror legs in _lvconvert_mirrors_aux()?
Other tests worked well so far. Thank you for fixing issues.
Thanks,
Taka
prev parent reply other threads:[~2010-03-16 2:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-05 23:57 [PATCH 0 of 10] LVM: mirrored log patches Jonathan Brassow
2010-03-11 22:53 ` Takahiro Yasui
2010-03-16 2:37 ` Takahiro Yasui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9EEED1.5060606@redhat.com \
--to=tyasui@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.