From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION. Date: Tue, 16 Mar 2010 15:04:09 +0200 Message-ID: <4B9F81C9.7020308@redhat.com> References: <1268736839-27371-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1268736839-27371-2-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4B9F7909.8010904@redhat.com> <4B9F8119.5040404@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, anthony@codemonkey.ws, ohmura.kei@lab.ntt.co.jp To: Yoshiaki Tamura Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59584 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935920Ab0CPNES (ORCPT ); Tue, 16 Mar 2010 09:04:18 -0400 In-Reply-To: <4B9F8119.5040404@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 03/16/2010 03:01 PM, Yoshiaki Tamura wrote: >>> -uint8_t *phys_ram_dirty; >>> +unsigned long *phys_ram_vga_dirty; >>> +unsigned long *phys_ram_code_dirty; >>> +unsigned long *phys_ram_migration_dirty; >> >> Would be nice to make this an array. > > > Thanks for pointing out. > I have a question regarding the index of the array. > From the compatibility perspective, I would prefer using the existing > macros. > > #define VGA_DIRTY_FLAG 0x01 > #define CODE_DIRTY_FLAG 0x02 > #define MIGRATION_DIRTY_FLAG 0x08 > > However, if I use them as is, I'll get a sparse array... > Is it acceptable to change these values like 0, 1, 2? Sure. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrWRX-0000Yg-JX for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:04:19 -0400 Received: from [199.232.76.173] (port=38702 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrWRX-0000YF-4u for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:04:19 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrWRW-0006Ct-Ab for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:04:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43415) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NrWRV-0006Co-U3 for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:04:18 -0400 Message-ID: <4B9F81C9.7020308@redhat.com> Date: Tue, 16 Mar 2010 15:04:09 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1268736839-27371-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1268736839-27371-2-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <4B9F7909.8010904@redhat.com> <4B9F8119.5040404@lab.ntt.co.jp> In-Reply-To: <4B9F8119.5040404@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: ohmura.kei@lab.ntt.co.jp, qemu-devel@nongnu.org, kvm@vger.kernel.org On 03/16/2010 03:01 PM, Yoshiaki Tamura wrote: >>> -uint8_t *phys_ram_dirty; >>> +unsigned long *phys_ram_vga_dirty; >>> +unsigned long *phys_ram_code_dirty; >>> +unsigned long *phys_ram_migration_dirty; >> >> Would be nice to make this an array. > > > Thanks for pointing out. > I have a question regarding the index of the array. > From the compatibility perspective, I would prefer using the existing > macros. > > #define VGA_DIRTY_FLAG 0x01 > #define CODE_DIRTY_FLAG 0x02 > #define MIGRATION_DIRTY_FLAG 0x08 > > However, if I use them as is, I'll get a sparse array... > Is it acceptable to change these values like 0, 1, 2? Sure. -- error compiling committee.c: too many arguments to function