From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/6] qemu-kvm: Introduce bit-based phys_ram_dirty, and bit-based dirty page checker. Date: Tue, 16 Mar 2010 15:11:10 +0200 Message-ID: <4B9F836E.9070504@redhat.com> References: <1268736839-27371-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, anthony@codemonkey.ws, ohmura.kei@lab.ntt.co.jp To: Yoshiaki Tamura Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16408 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320Ab0CPNLQ (ORCPT ); Tue, 16 Mar 2010 09:11:16 -0400 In-Reply-To: <1268736839-27371-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: > Experimental results: > Cond1: 1.9 ~ 61 times speed up > Cond2: 1.9 ~ 56 times speed up > Cond3: 1.9 ~ 59 times speed up > Cond4: 1.7 ~ 59 times speed up > Impressive results. What's the typical speedup? Closer to 1.9 or 61? Note the issue with the cache accesses for set_dirty() is only applicable to tcg, since kvm always updates the dirty bitmap in a batch (well, I/O also updates the bitmap). -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrWYH-0002dt-Jc for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:11:17 -0400 Received: from [199.232.76.173] (port=45763 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrWYH-0002dZ-19 for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:11:17 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NrWYG-0006fD-BE for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:11:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24933) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NrWYG-0006f9-0F for qemu-devel@nongnu.org; Tue, 16 Mar 2010 09:11:16 -0400 Message-ID: <4B9F836E.9070504@redhat.com> Date: Tue, 16 Mar 2010 15:11:10 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1268736839-27371-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> In-Reply-To: <1268736839-27371-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/6] qemu-kvm: Introduce bit-based phys_ram_dirty, and bit-based dirty page checker. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: ohmura.kei@lab.ntt.co.jp, qemu-devel@nongnu.org, kvm@vger.kernel.org On 03/16/2010 12:53 PM, Yoshiaki Tamura wrote: > Experimental results: > Cond1: 1.9 ~ 61 times speed up > Cond2: 1.9 ~ 56 times speed up > Cond3: 1.9 ~ 59 times speed up > Cond4: 1.7 ~ 59 times speed up > Impressive results. What's the typical speedup? Closer to 1.9 or 61? Note the issue with the cache accesses for set_dirty() is only applicable to tcg, since kvm always updates the dirty bitmap in a batch (well, I/O also updates the bitmap). -- error compiling committee.c: too many arguments to function