From: Andi Kleen <ak@linux.intel.com>
To: Nick Piggin <npiggin@suse.de>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Frank Mayhar <fmayhar@google.com>,
John Stultz <johnstul@us.ibm.com>,
linux-fsdevel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch 1/2] fs: cleanup files_lock
Date: Tue, 16 Mar 2010 07:41:16 -0700 [thread overview]
Message-ID: <4B9F988C.6090008@linux.intel.com> (raw)
In-Reply-To: <20100316094423.GM2869@laptop>
, Nick Piggin wrote:
> I would like to start sending bits of vfs scalability improvements to
> be reviewed and hopefully merged.
>
> I will start with files_lock. Last time this one came up, it was
> criticised because some hoped to get rid of files list, and because
> it didn't have enough justification of the scalability improvement.
>
> For the first criticism, it isn't any more difficult to rip out if
> we are ever able to remove files list. For the second, I have gathered
> some statistics and written better justification. Andi I believe is
> finding kbuild is becoming limited by files lock on larger systems.
Yes we're seeing files_list lock as the major bottleneck on a 32 CPU Threads
kernel build.
I did a quick review of the patch and it looks good to me.
Acked-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2010-03-16 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 9:44 [patch 1/2] fs: cleanup files_lock Nick Piggin
2010-03-16 9:46 ` [patch 2/2] fs: scale files_lock Nick Piggin
2010-03-16 14:41 ` Andi Kleen [this message]
2010-03-17 14:16 ` [patch 1/2] fs: cleanup files_lock Greg KH
2010-03-17 14:38 ` Nick Piggin
-- strict thread matches above, loose matches on Subject: below --
2009-09-04 6:51 [patch 00/33] my current vfs scalability patch queue npiggin
2009-09-04 6:51 ` [patch 03/33] fs: scale files_lock npiggin
2009-09-28 13:24 ` Peter Zijlstra
2009-10-01 2:16 ` Nick Piggin
[not found] ` <r2i3282373b1004011751j440635b3n484018db2e2bc50c@mail.gmail.com>
2010-04-02 2:24 ` [patch 1/2] fs: cleanup files_lock tim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9F988C.6090008@linux.intel.com \
--to=ak@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ebiederm@xmission.com \
--cc=fmayhar@google.com \
--cc=gregkh@suse.de \
--cc=johnstul@us.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.