From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: Avi Kivity <avi@redhat.com>, KVM list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] KVM: cleanup {kvm_vm_ioctl, kvm}_get_dirty_log()
Date: Wed, 17 Mar 2010 16:28:30 +0800 [thread overview]
Message-ID: <4BA092AE.3090206@cn.fujitsu.com> (raw)
In-Reply-To: <4BA09023.4000706@oss.ntt.co.jp>
Takuya Yoshikawa wrote:
>
> Oh, for such a tiny comment.
Your comment is valuable although it's tiny :-)
>
>
> What I said was just you may be able to use bitmap_empty() instead of
>
>> - for (i = 0; !is_dirty && i < n/sizeof(long); i++)
>> - is_dirty = memslot->dirty_bitmap[i];
>
> for x86's code too, if your patch for kvm_get_dirty_log() was correct.
While i look into x86's code, i found we can direct call kvm_get_dirty_log()
in kvm_vm_ioctl_get_dirty_log() to remove some unnecessary code, this is a
better cleanup way
Thanks,
Xiao
next prev parent reply other threads:[~2010-03-17 8:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 7:49 [PATCH v2] KVM: cleanup {kvm_vm_ioctl, kvm}_get_dirty_log() Xiao Guangrong
2010-03-17 8:17 ` Takuya Yoshikawa
2010-03-17 8:28 ` Xiao Guangrong [this message]
2010-03-17 8:41 ` Takuya Yoshikawa
2010-03-17 10:13 ` Xiao Guangrong
2010-03-18 2:48 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA092AE.3090206@cn.fujitsu.com \
--to=xiaoguangrong@cn.fujitsu.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.