From: Richard Henderson <rth@twiddle.net>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: "Martin Mohring" <martin.mohring@opensuse.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
qemu-devel@nongnu.org, "Jan-Simon Möller" <dl9pf@gmx.de>
Subject: Re: [Qemu-devel] [PATCH 0/6] Multi-level page tables and userland mapping fixes, v3
Date: Wed, 17 Mar 2010 07:32:06 -0700 [thread overview]
Message-ID: <4BA0E7E6.4060304@twiddle.net> (raw)
In-Reply-To: <20100317114807.GA13278@afflict.kos.to>
On 03/17/2010 04:48 AM, Riku Voipio wrote:
>>> page_check_range:
>>>
>>> - if (start + len < start)
>>> - /* we've wrapped around */
>>> ...
>>> + if (start + len - 1 < start) {
>>> + /* We've wrapped around. */
>>>
>>> This now blows up with len = 0;
>
>> Confirmed. A quick test with if (len > 0) around and ldconfig.real runs.
>
> Richard, would you be ok with that change? Or should we rather have explicit
>
> if (len == 0) return 0;
My personal preference is
if (len != 0 && start + len - 1 < start)
but don't let that stop anyone checking in any correct variant.
r~
prev parent reply other threads:[~2010-03-17 14:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 23:59 [Qemu-devel] [PATCH 0/6] Multi-level page tables and userland mapping fixes, v3 Richard Henderson
2010-03-10 22:33 ` [Qemu-devel] [PATCH 1/6] Move TARGET_PHYS_ADDR_SPACE_BITS to target-*/cpu.h Richard Henderson
2010-03-11 11:11 ` Aurelien Jarno
2010-03-11 15:19 ` Richard Henderson
2010-03-10 22:36 ` [Qemu-devel] [PATCH 2/6] Use TARGET_VIRT_ADDR_SPACE_BITS in h2g_valid Richard Henderson
2010-03-10 22:38 ` [Qemu-devel] [PATCH 3/6] linux-user: Use h2g_valid in qemu_vmalloc Richard Henderson
2010-03-10 23:39 ` [Qemu-devel] [PATCH 4/6] linux-user: Fix mmap_find_vma returning invalid addresses Richard Henderson
2010-03-10 23:53 ` [Qemu-devel] [PATCH 5/6] Implement multi-level page tables Richard Henderson
2010-03-13 22:48 ` Stefan Weil
2010-03-14 15:02 ` Paul Brook
2010-03-14 16:41 ` Aurelien Jarno
2010-03-10 23:57 ` [Qemu-devel] [PATCH 6/6] Fix last page errors in page_check_range and page_set_flags Richard Henderson
2010-03-12 18:51 ` [Qemu-devel] [PATCH 0/6] Multi-level page tables and userland mapping fixes, v3 Paul Brook
2010-03-12 19:26 ` Blue Swirl
2010-03-12 23:28 ` Paul Brook
2010-03-13 12:45 ` Aurelien Jarno
2010-03-13 14:00 ` Martin Mohring
2010-03-15 7:45 ` Riku Voipio
2010-03-15 12:46 ` Jan-Simon Möller
2010-03-15 14:48 ` Riku Voipio
2010-03-15 15:08 ` Jan-Simon Möller
2010-03-17 11:48 ` Riku Voipio
2010-03-17 14:32 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA0E7E6.4060304@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=dl9pf@gmx.de \
--cc=martin.mohring@opensuse.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.