From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NrufT-0003q7-Df
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 10:56:19 -0400
Received: from [199.232.76.173] (port=45518 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NrufS-0003pt-W6
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 10:56:19 -0400
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <rth@twiddle.net>) id 1NrufS-0006MJ-A5
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 10:56:18 -0400
Received: from are.twiddle.net ([75.149.56.221]:41642)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rth@twiddle.net>) id 1NrufR-0006MD-Jh
	for qemu-devel@nongnu.org; Wed, 17 Mar 2010 10:56:18 -0400
Message-ID: <4BA0ED8C.8000404@twiddle.net>
Date: Wed, 17 Mar 2010 07:56:12 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/4] tcg-hppa: Finish the port.
References: <cover.1268754659.git.rth@twiddle.net>	<6880f84577b97d0334b95f6ce031e61c65c2e88b.1268754659.git.rth@twiddle.net>
	<20100317015829.GC23195@zubnet.me.uk>
In-Reply-To: <20100317015829.GC23195@zubnet.me.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Brady <sdb@zubnet.me.uk>
Cc: qemu-devel@nongnu.org

On 03/16/2010 06:58 PM, Stuart Brady wrote:
> The tcg_reg_free() calls worry me slightly, but I assume they're safe...

Yeah, that one's rather gross.

Since Aurelien's generic div/rem patch I could simply remove all
that millicode stuff, including that tcg_reg_free, and let the
generic code handle this instead.  Which would get to the same
millicode routine via one or two extra levels of indirection.

Thoughts?


r~