From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Gardner Subject: Re: iptables pull request, add XT_RECENT_REAP support Date: Wed, 17 Mar 2010 14:21:23 -0600 Message-ID: <4BA139C3.3010805@tpi.com> References: <20100317184852.89F0DF89BB@sepang.rtg.net> <1268854497.2894.2.camel@edumazet-laptop> <4BA1310D.5080800@tpi.com> <1268855402.2894.18.camel@edumazet-laptop> Reply-To: timg@tpi.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kaber@trash.net, netfilter-devel@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail.tpi.com ([70.99.223.143]:4309 "EHLO mail.tpi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752791Ab0CQUVq (ORCPT ); Wed, 17 Mar 2010 16:21:46 -0400 In-Reply-To: <1268855402.2894.18.camel@edumazet-laptop> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On 03/17/2010 01:50 PM, Eric Dumazet wrote: > Le mercredi 17 mars 2010 =C3=A0 13:44 -0600, Tim Gardner a =C3=A9crit= : >> On 03/17/2010 01:34 PM, Eric Dumazet wrote: >>> Le mercredi 17 mars 2010 =C3=A0 12:48 -0600, Tim Gardner a =C3=A9cr= it : >>>> diff --git a/extensions/libxt_recent.man b/extensions/libxt_recent= =2Eman >>>> index 532c328..26e4fb9 100644 >>>> --- a/extensions/libxt_recent.man >>>> +++ b/extensions/libxt_recent.man >>>> @@ -41,6 +41,11 @@ This option must be used in conjunction with on= e of \fB\-\-rcheck\fP or >>>> \fB\-\-update\fP. When used, this will narrow the match to only= happen when the >>>> address is in the list and was seen within the last given numbe= r of seconds. >>>> .TP >>>> +\fB\-\-reap\fP \fIreap\fP >>>> +This option must be used in conjunction with \fB\-\-seconds\fP. W= hen used, this >>>> +will remove entries with the most recent timestamp older then \fB= \-\-seconds\fP >>>> +since the last packet was received. >>>> +.TP >>>> \fB\-\-hitcount\fP \fIhits\fP >>>> This option must be used in conjunction with one of \fB\-\-rche= ck\fP or >>>> \fB\-\-update\fP. When used, this will narrow the match to only= happen when the >>> >>> Are you sure this "most recent timestamp older then " is correct ? = ;) >>> >>> >>> >> >> That does kind of make my head hurt. Perhaps it is better stated, "W= hen >> used, this will remove entries that have not received a packet in th= e >> time specified by --seconds." >> > > Well, it will remove the oldest entry, if its age is more than time > specifed by --seconds. > > ie you wrote "most recent" instead of "least recent" ----> "oldest" > > > Which is probably why my head hurt. Do you agree that the second versio= n=20 is clearer? rtg --=20 Tim Gardner timg@tpi.com www.tpi.com OR 503-601-0234 x102 MT 406-443-5357 -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html