From: Aaro Koskinen <aaro.koskinen@nokia.com>
To: ext Arjan van de Ven <arjan@linux.intel.com>,
ext Tony Lindgren <tony@atomide.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/bootgraph.pl: ignore times until the clock is running
Date: Fri, 19 Mar 2010 16:15:24 +0200 [thread overview]
Message-ID: <4BA386FC.2000901@nokia.com> (raw)
In-Reply-To: <4BA26FE8.2070705@linux.intel.com>
Hi,
Arjan van de Ven wrote:
> On 3/18/2010 10:49, Aaro Koskinen wrote:
>> The clock used for printk.time=1 does not necessarily start running
>> from zero. On such platforms the bootgraph does not work properly as
>> the calculated boottime will be too long.
>
> can we fix the platform to be smarter instead ? I'd think that's needed anyway for various
> timers etc to actually work well
Hmm, on OMAP I have gotten so used to this "feature" that I never
thought it was a bug. However, I don't think it will affect anything
else than printk time stamps.
Anyway, I sent a fix proposal to linux-omap list:
http://marc.info/?l=linux-omap&m=126900738712041&w=2
>> To correct this, the patch modifies the script to accept only non-zero
>> start times. This ensures the report contains entries only from the
>> period when the clock was running.
>>
>> Signed-off-by: Aaro Koskinen<aaro.koskinen@nokia.com>
>
> nothing wrong with the patch itself... just sad that it's needed to work around such bugs ;(
>
> Acked-by: Arjan van de Ven <arjan@linux.intel.com>
I guess we can forget this patch if we agree the platform behaviour is
not correct.
A.
prev parent reply other threads:[~2010-03-19 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 17:49 [PATCH] scripts/bootgraph.pl: ignore times until the clock is running Aaro Koskinen
2010-03-18 18:24 ` Arjan van de Ven
2010-03-19 14:15 ` Aaro Koskinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA386FC.2000901@nokia.com \
--to=aaro.koskinen@nokia.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.