From: Ashwin Chaugule <ashwinc@codeaurora.org>
To: Tim Bird <tim.bird@am.sony.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
linux kernel <linux-kernel@vger.kernel.org>,
linux-arm-msm@vger.kernel.org
Subject: [PATCH] Make Function Duration Tracer work with __gnu_mcount_nc
Date: Fri, 19 Mar 2010 17:43:28 -0400 [thread overview]
Message-ID: <4BA3F000.5030404@codeaurora.org> (raw)
Is there a better way to fix this in the original ftrace_graph_caller ?
The lr isn't pushed on the stack before "bl mcount".
--
From: Ashwin Chaugule <ashwinc@quicinc.com>
Newer compilers use the __gnu_mcount_nc stub in every function
prologue. The lr of the instrumented function is pushed on the
stack before branching to __gnu_mcount_nc. Pop it before returning
back to instrumented function so that it can return to its parent
from its epilogue.
Signed-off-by: Ashwin Chaugule <ashwinc@quicinc.com>
---
arch/arm/kernel/entry-common.S | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
index b8a9e47..30feac3 100644
--- a/arch/arm/kernel/entry-common.S
+++ b/arch/arm/kernel/entry-common.S
@@ -144,6 +144,14 @@ ENTRY(__gnu_mcount_nc)
adr r0, ftrace_stub
cmp r0, r2
bne gnu_trace
+
+#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+ ldr r1, =ftrace_graph_return
+ ldr r2, [r1]
+ cmp r0, r2 @ if *ftrace_graph_return != ftrace_stub
+ bne new_ftrace_graph_caller
+#endif /* CONFIG_FUNCTION_GRAPH_TRACER */
+
ldmia sp!, {r0-r3, ip, lr}
bx ip
@@ -155,6 +163,18 @@ gnu_trace:
mov pc, r2
ldmia sp!, {r0-r3, ip, lr}
bx ip
+
+#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+ENTRY(new_ftrace_graph_caller) @ for use with __gnu_mcount_nc
+ sub r0, fp, #4 @ &lr of instrumented routine
(&parent)
+ mov r1, lr @ instrumented routine (func)
+ sub r1, r1, #MCOUNT_INSN_SIZE
+ mov r2, fp @ frame pointer
+ bl prepare_ftrace_return
+ ldmia sp!, {r0-r3, ip, lr} @ need to pop lr, pushed before
+ mov pc, ip @ bl __gnu_mcount_nc
+
+#endif /* CONFIG_FUNCTION_GRAPH_TRACER */
ENTRY(mcount)
stmdb sp!, {r0-r3, lr}
--
1.5.6.3
next reply other threads:[~2010-03-19 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 21:43 Ashwin Chaugule [this message]
2010-03-19 21:53 ` [PATCH] Make Function Duration Tracer work with __gnu_mcount_nc Tim Bird
2010-03-19 22:03 ` Ashwin Chaugule
2010-03-19 22:03 ` Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA3F000.5030404@codeaurora.org \
--to=ashwinc@codeaurora.org \
--cc=fweisbec@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.