From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NtQeB-0004Au-PG for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:17:15 -0400 Received: from [199.232.76.173] (port=56830 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NtQeB-0004Am-7D for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:17:15 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NtQe9-0006fi-VZ for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:17:15 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:47773) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NtQe9-0006fe-Mr for qemu-devel@nongnu.org; Sun, 21 Mar 2010 15:17:13 -0400 Received: by vws7 with SMTP id 7so987333vws.4 for ; Sun, 21 Mar 2010 12:17:13 -0700 (PDT) Message-ID: <4BA670B5.6010704@codemonkey.ws> Date: Sun, 21 Mar 2010 14:17:09 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] build error in current master References: <1269071241.1725.8.camel@localhost.localdomain> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paul Bolle , Anthony Liguori , qemu-devel@nongnu.org On 03/20/2010 03:14 AM, Blue Swirl wrote: > On 3/20/10, Paul Bolle wrote: > >> 0) Building current master (3290c4aac5b97bb1e3b2b28d94669f2c611ce84a, >> Introduce a default qmp session) fails here: >> >> $ make> /dev/null >> cc1: warnings being treated as errors >> curses.c: In function ‘curses_display_init’: >> curses.c:341: error: initialization from incompatible pointer type >> make: *** [curses.o] Error 1 >> >> 1) It seems caused by commit d7234f4d (committed half a day ago): >> >> $ git blame curses.c | grep 341 >> d7234f4d (Anthony Liguori 2010-03-17 17:59:26 -0500 341) static >> Notifier notifier = { .notify = curses_atexit }; >> >> $ git log -1 d7234f4d --pretty=short >> commit d7234f4d7e373a708e1df9ab565a71b71b189025 >> Author: Anthony Liguori >> >> Convert atexit users to exit_notifier >> >> Regards, >> > Fixed in HEAD. > I've reverted a bunch of these commits. They're still a work-in-progress. Looks like I pushed the wrong branch. Sorry for the noise. Regards, Anthony Liguori