From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Iua9mOWNq+W5syhQZXRlciBQYW4pIg==?= Date: Mon, 22 Mar 2010 12:14:04 +0000 Subject: Re: [PATCH] vfs: set proper level for printk in fs/super.c Message-Id: <4BA75F0C.5050509@redflag-linux.com> List-Id: References: <4BA4C92F.5070007@redflag-linux.com> <20100320133848.GD5331@bicker> In-Reply-To: <20100320133848.GD5331@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org On 03/20/2010 09:38 PM, Dan Carpenter wrote: > On Sat, Mar 20, 2010 at 09:10:07PM +0800, "潘卫平(Peter Pan)" wrote: >> Signed-off-by: Peter Pan(潘卫平) >> --- >> fs/super.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/super.c b/fs/super.c >> index f35ac60..60d720f 100644 >> --- a/fs/super.c >> +++ b/fs/super.c >> @@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *sb) >> >> /* Forget any remaining inodes */ >> if (invalidate_inodes(sb)) { >> - printk("VFS: Busy inodes after unmount of %s. " >> + printk(KERN_INFO "VFS: Busy inodes after unmount of %s. " >> "Self-destruct in 5 seconds. Have a nice day...\n", > > I'm pretty sure that both of these should be a higher priority than > KERN_INFO. > > regards, > dan carpenter > >> sb->s_id); >> } >> @@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_struct >> *work) >> } >> spin_unlock(&sb_lock); >> kfree(work); >> - printk("Emergency Remount complete\n"); >> + printk(KERN_INFO "Emergency Remount complete\n"); >> } >> >> void emergency_remount(void) >> -- >> 1.6.6 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > Signed-off-by: 潘卫平(Peter Pan) --- fs/super.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/super.c b/fs/super.c index f35ac60..baffd23 100644 --- a/fs/super.c +++ b/fs/super.c @@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *sb) /* Forget any remaining inodes */ if (invalidate_inodes(sb)) { - printk("VFS: Busy inodes after unmount of %s. " + printk(KERN_WARNING "VFS: Busy inodes after unmount of %s. " "Self-destruct in 5 seconds. Have a nice day...\n", sb->s_id); } @@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_struct *work) } spin_unlock(&sb_lock); kfree(work); - printk("Emergency Remount complete\n"); + printk(KERN_NOTICE "Emergency Remount complete\n"); } void emergency_remount(void) -- 1.6.6 -- Peter Pan(潘卫平) Red Flag Software Co.,Ltd From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Iua9mOWNq+W5syhQZXRlciBQYW4pIg==?= Subject: Re: [PATCH] vfs: set proper level for printk in fs/super.c Date: Mon, 22 Mar 2010 20:14:04 +0800 Message-ID: <4BA75F0C.5050509@redflag-linux.com> References: <4BA4C92F.5070007@redflag-linux.com> <20100320133848.GD5331@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Dan Carpenter Return-path: Received: from mail.redflag-linux.com ([219.237.229.196]:34196 "EHLO mail.redflag-linux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919Ab0CVMoe (ORCPT ); Mon, 22 Mar 2010 08:44:34 -0400 In-Reply-To: <20100320133848.GD5331@bicker> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 03/20/2010 09:38 PM, Dan Carpenter wrote: > On Sat, Mar 20, 2010 at 09:10:07PM +0800, "=E6=BD=98=E5=8D=AB=E5=B9=B3= (Peter Pan)" wrote: >> Signed-off-by: Peter Pan(=E6=BD=98=E5=8D=AB=E5=B9=B3) >> --- >> fs/super.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/fs/super.c b/fs/super.c >> index f35ac60..60d720f 100644 >> --- a/fs/super.c >> +++ b/fs/super.c >> @@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *= sb) >> >> /* Forget any remaining inodes */ >> if (invalidate_inodes(sb)) { >> - printk("VFS: Busy inodes after unmount of %s. " >> + printk(KERN_INFO "VFS: Busy inodes after unmount of %s. " >> "Self-destruct in 5 seconds. Have a nice day...\n", > > I'm pretty sure that both of these should be a higher priority than > KERN_INFO. > > regards, > dan carpenter > >> sb->s_id); >> } >> @@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_str= uct >> *work) >> } >> spin_unlock(&sb_lock); >> kfree(work); >> - printk("Emergency Remount complete\n"); >> + printk(KERN_INFO "Emergency Remount complete\n"); >> } >> >> void emergency_remount(void) >> -- >> 1.6.6 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe kernel-jan= itors" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > Signed-off-by: =E6=BD=98=E5=8D=AB=E5=B9=B3(Peter Pan) --- fs/super.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/super.c b/fs/super.c index f35ac60..baffd23 100644 --- a/fs/super.c +++ b/fs/super.c @@ -312,7 +312,7 @@ void generic_shutdown_super(struct super_block *sb) /* Forget any remaining inodes */ if (invalidate_inodes(sb)) { - printk("VFS: Busy inodes after unmount of %s. " + printk(KERN_WARNING "VFS: Busy inodes after unmount of %s. " "Self-destruct in 5 seconds. Have a nice day...\n", sb->s_id); } @@ -642,7 +642,7 @@ static void do_emergency_remount(struct work_struct= =20 *work) } spin_unlock(&sb_lock); kfree(work); - printk("Emergency Remount complete\n"); + printk(KERN_NOTICE "Emergency Remount complete\n"); } void emergency_remount(void) --=20 1.6.6 --=20 Peter Pan(=E6=BD=98=E5=8D=AB=E5=B9=B3) Red Flag Software Co.,Ltd -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html