From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: pablo@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] netlink: fix NETLINK_RECV_NO_ENOBUFS in netlink_set_err()
Date: Mon, 22 Mar 2010 16:38:02 +0100 [thread overview]
Message-ID: <4BA78EDA.8020003@trash.net> (raw)
In-Reply-To: <20100320.143027.116368032.davem@davemloft.net>
David Miller wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
> Date: Fri, 19 Mar 2010 01:24:42 +0100
>
>
>> Patrick McHardy wrote:
>>
>>> Generally the logic seems inverted, you should return an error
>>> to conntrack if userspace wasn't notified of the error.
>>>
>> Indeed, thanks. Are you OK with this patch instead?
>>
>
> I went over all of this and now the patches #1 and #2 look
> correct to me, so I've applied them to net-2.6
>
> Patrick let me know if you think any follow-on tidy ups
> are still necessary and we can add them.
The patch looks fine to me as well, thanks Dave.
next prev parent reply other threads:[~2010-03-22 15:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 23:29 [PATCH 0/3] several minor Netlink fixes Pablo Neira Ayuso
2010-03-16 23:29 ` [PATCH 1/3] netlink: fix NETLINK_RECV_NO_ENOBUFS in netlink_set_err() Pablo Neira Ayuso
2010-03-17 0:04 ` Pablo Neira Ayuso
2010-03-17 15:26 ` Patrick McHardy
2010-03-17 16:17 ` Pablo Neira Ayuso
2010-03-18 13:02 ` Patrick McHardy
2010-03-18 16:34 ` Pablo Neira Ayuso
2010-03-18 16:46 ` Patrick McHardy
2010-03-18 17:01 ` Pablo Neira Ayuso
2010-03-18 17:22 ` Patrick McHardy
2010-03-19 0:24 ` Pablo Neira Ayuso
2010-03-20 21:30 ` David Miller
2010-03-22 15:38 ` Patrick McHardy [this message]
2010-03-16 23:30 ` [PATCH 2/3] netfilter: ctnetlink: fix reliable event delivery if message building fails Pablo Neira Ayuso
2010-03-16 23:30 ` [PATCH 3/3] netlink: fix unaligned access in nla_get_be64() Pablo Neira Ayuso
2010-03-20 5:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA78EDA.8020003@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.