From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
To: Avi Kivity <avi@redhat.com>
Cc: KVM list <kvm@vger.kernel.org>
Subject: Re: Updating dirty bitmap by non-atomic set bit is safe?
Date: Tue, 23 Mar 2010 19:17:03 +0900 [thread overview]
Message-ID: <4BA8951F.7060109@oss.ntt.co.jp> (raw)
In-Reply-To: <4BA8875D.3000506@redhat.com>
Avi Kivity wrote:
> On 03/23/2010 08:12 AM, Takuya Yoshikawa wrote:
>> Hi, does anybody knows about this?
>>
>>
>> Currently, dirty bitmap is updated by generic___set_le_bit().
>> I checked the git log and mail archives but could not find any
>> explanation why replacing set_bit() by generic___set_le_bit() is
>> safe.
>>
>
> IIRC it's protected by the mmu spinlock.
>
So the fact is the old version did extra protection, thank you.
prev parent reply other threads:[~2010-03-23 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 6:12 Updating dirty bitmap by non-atomic set bit is safe? Takuya Yoshikawa
2010-03-23 9:18 ` Avi Kivity
2010-03-23 10:17 ` Takuya Yoshikawa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA8951F.7060109@oss.ntt.co.jp \
--to=yoshikawa.takuya@oss.ntt.co.jp \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.