diff for duplicates of <4BA8A100.3000301@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 7f045bb..a067ac6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,7 +25,7 @@ On 03/23/2010 11:59 AM, Jean Delvare wrote: >>>> - long val = simple_strtol(buf, NULL, 10); >>>> + long val; >>>> + ->>>> + if (strict_strtol(buf, 10,&val) = -EINVAL) +>>>> + if (strict_strtol(buf, 10,&val) == -EINVAL) >>>> + return -EINVAL; >>> >>> That's not correct. You want to return an error if strict_strtol() @@ -74,8 +74,3 @@ No objections from me, IOW I'm still ack. Regards, Hans - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index ebb00d3..e10cb49 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,8 +4,8 @@ "ref\020100322114157.GA14077@salidar.me.mortis.eu\0" "ref\020100323115921.7d094e64@hyperion.delvare\0" "From\0Hans de Goede <hdegoede@redhat.com>\0" - "Subject\0Re: [lm-sensors] [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul)\0" - "Date\0Tue, 23 Mar 2010 11:07:44 +0000\0" + "Subject\0Re: [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) instead of simple_strto$1\0" + "Date\0Tue, 23 Mar 2010 12:07:44 +0100\0" "To\0Jean Delvare <khali@linux-fr.org>\0" "Cc\0Giel van Schijndel <me@mortis.eu>" Jonathan Cameron <jic23@cam.ac.uk> @@ -40,7 +40,7 @@ ">>>> -\tlong val = simple_strtol(buf, NULL, 10);\n" ">>>> +\tlong val;\n" ">>>> +\n" - ">>>> +\tif (strict_strtol(buf, 10,&val) = -EINVAL)\n" + ">>>> +\tif (strict_strtol(buf, 10,&val) == -EINVAL)\n" ">>>> +\t\treturn -EINVAL;\n" ">>>\n" ">>> That's not correct. You want to return an error if strict_strtol()\n" @@ -88,11 +88,6 @@ "\n" "Regards,\n" "\n" - "Hans\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + Hans -248c48b18cef619ed27274faa93235f31200abcc615e390bbf9e112af53f11af +874336841c06b50531d37ae07dd387b6f5e77b48a7bea24ddfe3975bac3cf1b1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.