From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks Date: Tue, 23 Mar 2010 14:25:33 +0200 Message-ID: <4BA8B33D.7040903@redhat.com> References: <4BA74694.2080300@siemens.com> <4BA89706.5090808@redhat.com> <4BA8A432.7070303@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:61106 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751946Ab0CWMZe (ORCPT ); Tue, 23 Mar 2010 08:25:34 -0400 In-Reply-To: <4BA8A432.7070303@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 03/23/2010 01:21 PM, Jan Kiszka wrote: > >> A 44-byte TSS has a limit of 43 (just like a 4GB segment has a limit of >> 0xffffffff), so there is an off-by-one here. >> >> > Right - you just found an (harmless) off-by-one in our legacy OS as well > (I blindly copied its limit). > > It's a very common error. -- error compiling committee.c: too many arguments to function