From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86 emulator: fix unlocked CMPXCHG8B emulation. Date: Tue, 23 Mar 2010 14:34:11 +0200 Message-ID: <4BA8B543.4060409@redhat.com> References: <20100321145836.GH13522@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39807 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037Ab0CWMeN (ORCPT ); Tue, 23 Mar 2010 08:34:13 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2NCYC9e000502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 23 Mar 2010 08:34:13 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2NCYC4Y031785 for ; Tue, 23 Mar 2010 08:34:12 -0400 In-Reply-To: <20100321145836.GH13522@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/21/2010 04:58 PM, Gleb Natapov wrote: > > When CMPXCHG8B is executed without LOCK prefix it is racy. Preserve this > behaviour in emulator too. > Applied, thanks. -- error compiling committee.c: too many arguments to function