From: William Cohen <wcohen@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Make kernel-doc ignore __init_or_module
Date: Tue, 23 Mar 2010 12:07:11 -0400 [thread overview]
Message-ID: <4BA8E72F.2080402@redhat.com> (raw)
In-Reply-To: <4BA8E0F8.4050708@oracle.com>
On 03/23/2010 11:40 AM, Randy Dunlap wrote:
> On 03/23/10 08:31, William Cohen wrote:
>>
>> Function definitions may include __init_or_module. kernel-doc needs to
>> filter those out to avoid confusing __init_or_module for the function name.
>>
>> Signed-off-by: William cohen <wcohen@redhat.com>
>> ---
>> scripts/kernel-doc | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
>> index c7865c3..1d8db58 100755
>> --- a/scripts/kernel-doc
>> +++ b/scripts/kernel-doc
>> @@ -1728,6 +1728,7 @@ sub dump_function($$) {
>> $prototype =~ s/^noinline +//;
>> $prototype =~ s/__devinit +//;
>> $prototype =~ s/__init +//;
>> + $prototype =~ s/__init_or_module +//;
>> $prototype =~ s/^#\s*define\s+//; #ak added
>> $prototype =~ s/__attribute__\s*\(\([a-z,]*\)\)//;
>>
>
> Hi,
>
> Yes, I know. I've already sent this patch to Linus more than once
> and now Andrew has it for merging...
>
Thanks, Randy. -Will
prev parent reply other threads:[~2010-03-23 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 15:31 [PATCH] Make kernel-doc ignore __init_or_module William Cohen
2010-03-23 15:40 ` Randy Dunlap
2010-03-23 16:07 ` William Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA8E72F.2080402@redhat.com \
--to=wcohen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.