From: tristan <tristan.ye@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] Ocfs2: Teach truncating and punching-hole codes to handle fastsymlink.
Date: Wed, 24 Mar 2010 10:21:57 +0800 [thread overview]
Message-ID: <4BA97745.8040009@oracle.com> (raw)
In-Reply-To: <20100324021306.GH31783@mail.oracle.com>
Joel Becker wrote:
> On Wed, Mar 24, 2010 at 09:10:13AM +0800, tristan wrote:
>> Joel Becker wrote:
>>> On Tue, Mar 23, 2010 at 04:04:44PM +0800, Tristan Ye wrote:
>>>> Fast symlink can be treated the same way as inline file for truncating
>>>> and hole punching, since the mechanism is quite simliar per se.
>>>>
>>>> Signed-off-by: Tristan Ye <tristan.ye@oracle.com>
>>> The patch looks good, with perhaps a bit over-zealous
>>> parentheses ;-) Is this fixing a bug someone has hit?
>> Not exactly,
>>
>> Sunil reported such a bug from userspace in libocfs2, I suddenly
>> realised that we could also do the same in fs.
>
> The difference is that we never call the truncate code for fast
> symlinks or inline data in the kernel. We do in libocfs2.
Really?
Truncating for inline data is common I guess, for symlink, we may lack
of method to truncate it from userspace via ftruncate(2).
But it's ok to be there, right?
Tristan.
>
> Joel
>
next prev parent reply other threads:[~2010-03-24 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 8:04 [Ocfs2-devel] [PATCH 1/1] Ocfs2: Teach truncating and punching-hole codes to handle fastsymlink Tristan Ye
2010-03-23 19:52 ` Joel Becker
2010-03-24 1:10 ` tristan
2010-03-24 2:13 ` Joel Becker
2010-03-24 2:21 ` tristan [this message]
2010-03-24 2:32 ` Joel Becker
2010-03-24 2:51 ` tristan
2010-03-24 4:14 ` Joel Becker
2010-03-25 18:25 ` Sunil Mushran
2010-03-26 1:12 ` tristan
2010-03-24 1:29 ` tristan
-- strict thread matches above, loose matches on Subject: below --
2010-03-24 1:05 Tristan Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA97745.8040009@oracle.com \
--to=tristan.ye@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.