All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH v2] improve activation monitoring option processing
Date: Wed, 24 Mar 2010 09:49:36 +0100	[thread overview]
Message-ID: <4BA9D220.2070409@redhat.com> (raw)
In-Reply-To: <1269372233-4199-1-git-send-email-snitzer@redhat.com>

On 03/23/2010 08:23 PM, Mike Snitzer wrote:
> Add "monitoring" option to "activation" section of lvm.conf
> 
> Have clvmd consult the lvm.conf "activation/monitoring" too.

I am not sure if this is correct, there is flag sent from
calling process. I think the process should not send
this flag in the first place and not read lvm.conf later.

and specifically NOT in do_lock_lv for every LV.

> Introduce toollib.c:get_activation_monitoring_mode().
> 
> Error out when both --monitor and --ignoremonitoring are provided.
> 
> Add --monitor and --ignoremonitoring support to lvcreate.  Update
> lvcreate man page accordingly.
> 
> Clarify that '--monitor' controls the start and stop of monitoring in
> the {vg,lv}change man pages.


Sorry if it is dumb question, but if user disables monitoring,
do we still emit "block_on_error" for mirror table?

If so, is it correct? When a fail happens mirror all IOs waits
for userspace to do something - but there is no monitoring active.

Probably ok if command run manually (like in itnitrd, because we later
start dmeventd in initscripts) but if it is disabled permanently in lvm.conf?

Milan



  reply	other threads:[~2010-03-24  8:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-23 19:23 [PATCH v2] improve activation monitoring option processing Mike Snitzer
2010-03-24  8:49 ` Milan Broz [this message]
2010-03-24  9:19 ` Milan Broz
2010-03-24 13:07   ` Mike Snitzer
2010-03-24 15:44     ` Mike Snitzer
2010-03-25 21:51       ` Mike Snitzer
2010-03-26  2:59         ` [PATCH] allow disabled dmeventd monitoring to propagate via clvmd Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA9D220.2070409@redhat.com \
    --to=mbroz@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.