From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH] Bail out when VCPU_CREATE fails
Date: Wed, 24 Mar 2010 11:32:23 +0200 [thread overview]
Message-ID: <4BA9DC27.6020705@redhat.com> (raw)
In-Reply-To: <1269254953-20323-1-git-send-email-agraf@suse.de>
On 03/22/2010 12:49 PM, Alexander Graf wrote:
> When we fail to create a VCPU we have no way to tell our callers that something
> failed. So the caller happily uses a completely broken state.
>
> This code should become deprecated in the process of converting qemu-kvm to
> qemu anyways, so let's not care about remdeling it but just bailing out when
> something breaks. Also give the user a hint on why the VCPU_CREATE might have
> failed.
>
> This fixes a segmentation fault with -smp> VCPU_MAX in the host kernel.
>
>
Applied, thanks. Note, kvm reports the number of supported vcpus using
KVM_CAP_NR_VCPUS, so we can fail in vl.c.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-03-24 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 10:49 [PATCH] Bail out when VCPU_CREATE fails Alexander Graf
2010-03-24 9:32 ` Avi Kivity [this message]
2010-03-24 9:33 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA9DC27.6020705@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.