From: Jeff Garzik <jgarzik@pobox.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-ide@vger.kernel.org,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Subject: Re: [PATCH] ahci: Turn off DMA engines when there's no device attached
Date: Wed, 24 Mar 2010 10:43:51 -0400 [thread overview]
Message-ID: <4BAA2527.4030204@pobox.com> (raw)
In-Reply-To: <20100324141912.GA18644@srcf.ucam.org>
On 03/24/2010 10:19 AM, Matthew Garrett wrote:
> On Wed, Mar 10, 2010 at 03:32:30PM -0500, Matthew Garrett wrote:
>> According to section 10.3.1 of the AHCI spec, PxCMD.ST must not be set
>> unless there's a device attached. Following this saves us a measurable
>> quantity of power and does not impair hotplug support. Based on a patch
>> by Kristen Carlson Accardi.
>>
>> Signed-off-by: Matthew Garrett<mjg@redhat.com>
>> Cc: Kristen Carlson Accardi<kristen.c.accardi@intel.com>
>> ---
>> drivers/ata/ahci.c | 19 +++++++++++++++++++
>> 1 files changed, 19 insertions(+), 0 deletions(-)
(please don't top-post, it makes replying more difficult)
> Any feedback on this?
It should be fine, but I have to rebase it onto the latest upstream ahci
(libata-dev.git#upstream), so it's been waiting on that...
Jeff
next prev parent reply other threads:[~2010-03-24 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 20:32 [PATCH] ahci: Turn off DMA engines when there's no device attached Matthew Garrett
2010-03-24 14:19 ` Matthew Garrett
2010-03-24 14:43 ` Jeff Garzik [this message]
2010-03-28 4:39 ` Jeff Garzik
2010-03-29 21:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAA2527.4030204@pobox.com \
--to=jgarzik@pobox.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.