[PATCH] Fix gdbserver-xen support on older kernels.

["Justin T. Gibbs" <gibbs@scsiguy.com>]

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

The xc_ptrace API relies on errno for passing success/failure indication
back to callers.  However, mapping operations that fall back on legacy
APIs may leave errno set to a non-zero result even thought the operation
is successful.  This patch resets errno after successful map operations
so that xc_ptrace doesn't inadvertently return a failure.

Signed-off-by: Justin Gibbs <gibbs@scsiguy.com>

[-- Attachment #2: xc_ptrace.patch --]
[-- Type: text/plain, Size: 603 bytes --]

Index: xen-4.0.0-testing/tools/libxc/xc_ptrace.c
===================================================================
--- a/tools/libxc/xc_ptrace.c	Mon Mar 15 13:25:30 2010 +0000
+++ b/tools/libxc/xc_ptrace.c	Mon Mar 15 10:22:23 2010 -0600
@@ -193,6 +193,13 @@
     if (map == NULL)
         return NULL;
 
+    /*
+     * Due to the use of API fallback code in libxc, errno may
+     * be clobberred during successful operations.  Since the caller
+     * of xc_ptrace is depending on errno for return status, clear
+     * errno here.
+     */
+    errno = 0;
     return map + (va & ~PAGE_MASK);
 }
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel