All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: fix build error for CONFIG_IWLAGN=n
Date: Wed, 24 Mar 2010 15:59:44 -0700	[thread overview]
Message-ID: <4BAA9960.9070102@oracle.com> (raw)
In-Reply-To: <1269465799-19060-1-git-send-email-linville@tuxdriver.com>

On 03/24/10 14:23, John W. Linville wrote:
> drivers/net/wireless/iwlwifi/iwl-rx.c: In function 'iwl_good_ack_health':
> drivers/net/wireless/iwlwifi/iwl-rx.c:647: error: 'struct iwl_priv' has no member named '_agn'
> 
> Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>

ACK if you end up using this one.

Thanks.

> ---
>  drivers/net/wireless/iwlwifi/iwl-rx.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-rx.c b/drivers/net/wireless/iwlwifi/iwl-rx.c
> index b6a64d8..2fa30df 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-rx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
> @@ -621,6 +621,7 @@ static void iwl_accumulative_statistics(struct iwl_priv *priv,
>  #define BA_TIMEOUT_CNT (5)
>  #define BA_TIMEOUT_MAX (16)
>  
> +#if defined(CONFIG_IWLAGN) || defined(CONFIG_IWLAGN_MODULE)
>  /**
>   * iwl_good_ack_health - checks for ACK count ratios, BA timeout retries.
>   *
> @@ -670,6 +671,7 @@ bool iwl_good_ack_health(struct iwl_priv *priv,
>  	return rc;
>  }
>  EXPORT_SYMBOL(iwl_good_ack_health);
> +#endif
>  
>  /**
>   * iwl_good_plcp_health - checks for plcp error.


-- 
~Randy

      parent reply	other threads:[~2010-03-24 23:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24  5:17 linux-next: Tree for March 24 Stephen Rothwell
2010-03-24  7:29 ` Dmitry Torokhov
2010-03-24 19:44 ` linux-next: Tree for March 24 (staging/vt66*) Randy Dunlap
2010-03-25 13:00   ` Forest Bond
2010-03-25 15:38     ` Randy Dunlap
2010-04-17 15:03       ` [PATCH] vt6656: Rename hostap_set_hostapd, hostap_iotctl Forest Bond
2010-04-17 15:03       ` [PATCH] vt6655: " Forest Bond
2010-03-24 20:19 ` linux-next: Tree for March 24 (iwlwifi) Randy Dunlap
2010-03-24 21:23   ` [PATCH] iwlwifi: fix build error for CONFIG_IWLAGN=n John W. Linville
     [not found]     ` <1269465799-19060-1-git-send-email-linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2010-03-24 21:33       ` Johannes Berg
2010-03-24 21:33         ` Johannes Berg
2010-03-24 21:42         ` reinette chatre
2010-03-24 22:37           ` John W. Linville
2010-03-24 22:37             ` John W. Linville
2010-03-24 22:41             ` reinette chatre
2010-03-24 23:38               ` John W. Linville
2010-03-25 16:33                 ` reinette chatre
2010-03-24 22:59     ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BAA9960.9070102@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.