From: Akira Fujita <a-fujita@rs.jp.nec.com>
To: tytso@mit.edu
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>, linux-ext4@vger.kernel.org
Subject: Re: New compiler warning in 2.6.34-rc1: 'start_ext.ee_block' may be used uninitialized
Date: Thu, 25 Mar 2010 11:42:54 +0900 [thread overview]
Message-ID: <4BAACDAE.7010901@rs.jp.nec.com> (raw)
In-Reply-To: <20100315154142.GB4484@thunk.org>
(2010/03/16 0:41), tytso@mit.edu wrote:
> On Mon, Mar 15, 2010 at 03:42:39PM +0100, Stefan Richter wrote:
>> Hi,
>>
>> I saw the following scroll by during kernel compilation:
>>
>> fs/ext4/move_extent.c: In function 'mext_leaf_block':
>>
>> fs/ext4/move_extent.c:478: warning: 'start_ext.ee_block' may be used
>> uninitialized in this function
>>
>> Is it real? It seems that the initial start_ext.ee_len = 0 guards
>> against accidental use of an uninitialized start_ext.ee_block, but maybe
>> I missed something.
>
>> From my review of the code the fact that ee_len is set to zero should
> make this be safe, but my preference would be to clear
> start_ext.ee_block as well to prevent the warning from coming up
> (since false positives clutter up warnings and might cause us to miss
> a warning which isn't so benign).
>
> Akira-san, do you agree that it is currently is safe?
>
Sorry for the late reply.
The patch (gcc-wall-cleanup-in-move_extent.c) in ext4 patch queue
looks good to me.
Thanks,
Akira Fujita
prev parent reply other threads:[~2010-03-25 2:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 14:42 New compiler warning in 2.6.34-rc1: 'start_ext.ee_block' may be used uninitialized Stefan Richter
2010-03-15 15:41 ` tytso
2010-03-25 2:42 ` Akira Fujita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAACDAE.7010901@rs.jp.nec.com \
--to=a-fujita@rs.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.