From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] unneeded exported function i2c_mux_add_device
Date: Thu, 25 Mar 2010 07:39:06 +0100 [thread overview]
Message-ID: <4BAB050A.7030605@denx.de> (raw)
In-Reply-To: <ac9c93b11003241203q739d2a43h24c789ceca4ff12c@mail.gmail.com>
Hello Frans,
Frans Meulenbroeks wrote:
> While grepping some sources I bumped upon i2c_mux_add_device
> This one is implemented in cmd_i2c.c and exported through i2c.h.
> However no-one outside cmd_i2c.c is using it:
>
> frans at linux-suse:~/u-boot> grep -r i2c_mux_add_device .
> ./common/cmd_i2c.c:int i2c_mux_add_device(I2C_MUX_DEVICE *dev)
> ./common/cmd_i2c.c: i2c_mux_add_device (device);
> ./include/i2c.h:int i2c_mux_add_device(I2C_MUX_DEVICE *dev);
> frans at linux-suse:~/u-boot>
>
> Should we make this function static and remove from the .h file?
Yep, good catch. Please post a patch.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2010-03-25 6:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 19:03 [U-Boot] unneeded exported function i2c_mux_add_device Frans Meulenbroeks
2010-03-25 6:39 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAB050A.7030605@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.