From: Miao Xie <miaox@cn.fujitsu.com>
To: Chris Mason <chris.mason@oracle.com>,
Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: [PATCH 09/18] btrfs: Fix return value of read_extent_buffer_pages() when lock page failed
Date: Thu, 25 Mar 2010 20:33:27 +0800 [thread overview]
Message-ID: <4BAB5817.8020803@cn.fujitsu.com> (raw)
From: Zhao Lei <zhaolei@cn.fujitsu.com>
read_extent_buffer_pages() should return error value instead of 0 when
lock page failed, we fix this problem.
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
---
fs/btrfs/extent_io.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index bdfbfa6..3194c79 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -3419,8 +3419,10 @@ int read_extent_buffer_pages(struct extent_io_tree *tree,
for (i = start_i; i < num_pages; i++) {
page = extent_buffer_page(eb, i);
if (!wait) {
- if (!trylock_page(page))
+ if (!trylock_page(page)) {
+ ret = -EIO;
goto unlock_exit;
+ }
} else {
lock_page(page);
}
--
1.6.5.2
next reply other threads:[~2010-03-25 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 12:33 Miao Xie [this message]
2010-03-31 0:09 ` [PATCH 09/18] btrfs: Fix return value of read_extent_buffer_pages() when lock page failed Chris Mason
2010-03-31 4:04 ` Zhaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAB5817.8020803@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.