Re: [PATCH 4/5] netfilter: xtables: consolidate code into xt_request_find_match

[Patrick McHardy <kaber@trash.net>]

Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
> ---
>  include/linux/netfilter/x_tables.h |    1 +
>  net/bridge/netfilter/ebtables.c    |    5 +----
>  net/ipv4/netfilter/ip_tables.c     |   18 ++++++++----------
>  net/ipv6/netfilter/ip6_tables.c    |   18 ++++++++----------
>  net/netfilter/x_tables.c           |   11 +++++++++++
>  5 files changed, 29 insertions(+), 24 deletions(-)
> 
> diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
> index f8f5551..3c13d24 100644
> --- a/include/linux/netfilter/x_tables.h
> +++ b/include/linux/netfilter/x_tables.h
> @@ -436,6 +436,7 @@ extern struct xt_table_info *xt_replace_table(struct xt_table *table,
>  
>  extern struct xt_match *xt_find_match(u8 af, const char *name, u8 revision);
>  extern struct xt_target *xt_find_target(u8 af, const char *name, u8 revision);
> +extern struct xt_match *xt_request_find_match(uint8_t, const char *, uint8_t);
>  extern struct xt_target *xt_request_find_target(u8 af, const char *name,
>  						u8 revision);

Just for the sake of consistency, please use "u8" and specify the
parameter names.