From: Scott McNutt <smcnutt@psyent.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Rejected: [PATCH v2] nios2: flush data cache after relocating code in start.S
Date: Thu, 25 Mar 2010 09:11:26 -0400 [thread overview]
Message-ID: <4BAB60FE.40308@psyent.com> (raw)
In-Reply-To: <1269442321-4229-1-git-send-email-thomas@wytron.com.tw>
Hi Thomas,
Patch is reject.
> diff --git a/cpu/nios2/start.S b/cpu/nios2/start.S
> index 31cd5b0..61784d8 100644
> --- a/cpu/nios2/start.S
> +++ b/cpu/nios2/start.S
> @@ -98,6 +98,17 @@ _cur: movhi r5, %hi(_cur - _start)
> stwio r7, 0(r5)
--------^^^^^
The existing code uses stxio instructions, which by their
very purpose, bypass the cache. So there's no need to flush
the data cache.
One could argue that invalidating the _instruction_ cache
may be necessary ... but I doubt it, given that first
instructions after reset invalidate the entire instruction
cache. It would be a defensive nevertheless.
Regards,
--Scott
prev parent reply other threads:[~2010-03-25 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 6:16 [U-Boot] [PATCH] nios2: flush dcache after relocating code in start.S Thomas Chou
2010-03-24 14:52 ` [U-Boot] [PATCH v2] nios2: flush data cache " Thomas Chou
2010-03-25 13:11 ` Scott McNutt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAB60FE.40308@psyent.com \
--to=smcnutt@psyent.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.